Skip to content

float activity aggregate updated to results #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
Merged

float activity aggregate updated to results #919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions TransactionProcessor.Aggregates.Tests/FloatActivityAggregateTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Shouldly;
using SimpleResults;
using TransactionProcessor.Testing;

namespace TransactionProcessor.Aggregates.Tests;
Expand All @@ -15,7 +16,8 @@ public void FloatActivityAggregate_CanBeCreated_IsCreated()
[Fact]
public void FloatActivityAggregate_RecordCreditPurchase_PurchaseRecorded() {
FloatActivityAggregate aggregate = FloatActivityAggregate.Create(TestData.FloatAggregateId);
aggregate.RecordCreditPurchase(TestData.EstateId, TestData.CreditPurchasedDateTime, TestData.FloatCreditAmount, TestData.FloatCreditId);
Result result = aggregate.RecordCreditPurchase(TestData.EstateId, TestData.CreditPurchasedDateTime, TestData.FloatCreditAmount, TestData.FloatCreditId);
result.IsSuccess.ShouldBeTrue();
aggregate.CreditCount.ShouldBe(1);
aggregate.Credits.Contains(TestData.FloatCreditId).ShouldBeTrue();
}
Expand All @@ -26,15 +28,17 @@ public void FloatActivityAggregate_RecordCreditPurchase_DuplicateCredit_Purchase
FloatActivityAggregate aggregate = FloatActivityAggregate.Create(TestData.FloatAggregateId);
aggregate.RecordCreditPurchase(TestData.EstateId, TestData.CreditPurchasedDateTime, TestData.FloatCreditAmount, TestData.FloatCreditId);
aggregate.CreditCount.ShouldBe(1);
aggregate.RecordCreditPurchase(TestData.EstateId, TestData.CreditPurchasedDateTime, TestData.FloatCreditAmount, TestData.FloatCreditId);
Result result = aggregate.RecordCreditPurchase(TestData.EstateId, TestData.CreditPurchasedDateTime, TestData.FloatCreditAmount, TestData.FloatCreditId);
result.IsSuccess.ShouldBeTrue();
aggregate.CreditCount.ShouldBe(1);
}

[Fact]
public void FloatActivityAggregate_RecordTransactionAgainstFloat_TransactionRecorded()
{
FloatActivityAggregate aggregate = FloatActivityAggregate.Create(TestData.FloatAggregateId);
aggregate.RecordTransactionAgainstFloat(TestData.EstateId, TestData.TransactionDateTime, TestData.TransactionAmount, TestData.TransactionId);
Result result = aggregate.RecordTransactionAgainstFloat(TestData.EstateId, TestData.TransactionDateTime, TestData.TransactionAmount, TestData.TransactionId);
result.IsSuccess.ShouldBeTrue();
aggregate.DebitCount.ShouldBe(1);
aggregate.Debits.Contains(TestData.TransactionId).ShouldBeTrue();
}
Expand All @@ -45,7 +49,8 @@ public void FloatActivityAggregate_RecordTransactionAgainstFloat_DuplicateTransa
FloatActivityAggregate aggregate = FloatActivityAggregate.Create(TestData.FloatAggregateId);
aggregate.RecordTransactionAgainstFloat(TestData.EstateId, TestData.TransactionDateTime, TestData.TransactionAmount, TestData.TransactionId);
aggregate.DebitCount.ShouldBe(1);
aggregate.RecordTransactionAgainstFloat(TestData.EstateId, TestData.TransactionDateTime, TestData.TransactionAmount, TestData.TransactionId);
Result result = aggregate.RecordTransactionAgainstFloat(TestData.EstateId, TestData.TransactionDateTime, TestData.TransactionAmount, TestData.TransactionId);
result.IsSuccess.ShouldBeTrue();
aggregate.DebitCount.ShouldBe(1);
}
}
21 changes: 13 additions & 8 deletions TransactionProcessor.Aggregates/FloatActivityAggregate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using Shared.DomainDrivenDesign.EventSourcing;
using Shared.EventStore.Aggregate;
using Shared.General;
using SimpleResults;
using TransactionProcessor.DomainEvents;

namespace TransactionProcessor.Aggregates
Expand All @@ -22,31 +23,35 @@ public static void PlayEvent(this FloatActivityAggregate aggregate,
aggregate.Debits.Add(domainEvent.DebitId);
}

public static void RecordCreditPurchase(this FloatActivityAggregate aggregate,
public static Result RecordCreditPurchase(this FloatActivityAggregate aggregate,
Guid estateId,
DateTime activityDateTime,
Decimal creditAmount,
Guid creditId)
{

if (aggregate.Credits.Any(c => c == creditId))
return;
return Result.Success();

FloatActivityDomainEvents.FloatAggregateCreditedEvent floatAggregateCreditedEvent = new(aggregate.AggregateId, estateId, activityDateTime, creditAmount, creditId);
aggregate.ApplyAndAppend(floatAggregateCreditedEvent);

return Result.Success();
}

public static void RecordTransactionAgainstFloat(this FloatActivityAggregate aggregate,
Guid estateId,
DateTime activityDateTime,
Decimal transactionAmount,
Guid transactionId)
public static Result RecordTransactionAgainstFloat(this FloatActivityAggregate aggregate,
Guid estateId,
DateTime activityDateTime,
Decimal transactionAmount,
Guid transactionId)
{
if (aggregate.Debits.Any(c => c == transactionId))
return;
return Result.Success();

FloatActivityDomainEvents.FloatAggregateDebitedEvent floatAggregateCreditedEvent = new(aggregate.AggregateId, estateId, activityDateTime, transactionAmount, transactionId);
aggregate.ApplyAndAppend(floatAggregateCreditedEvent);

return Result.Success();
}
}

Expand Down
9 changes: 6 additions & 3 deletions TransactionProcessor.BusinessLogic/Services/FloatDomainService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,9 @@ public async Task<Result> RecordCreditPurchase(FloatActivityCommands.RecordCredi

FloatActivityAggregate floatActivityAggregate = getFloatActivityResult.Data;

floatActivityAggregate.RecordCreditPurchase(command.EstateId, command.CreditPurchasedDateTime, command.Amount, command.CreditId);

Result stateResult = floatActivityAggregate.RecordCreditPurchase(command.EstateId, command.CreditPurchasedDateTime, command.Amount, command.CreditId);
if (stateResult.IsFailed)
return ResultHelpers.CreateFailure(stateResult);
Result saveResult = await this.AggregateService.Save(floatActivityAggregate, cancellationToken);
if (saveResult.IsFailed)
return ResultHelpers.CreateFailure(saveResult);
Expand Down Expand Up @@ -175,7 +176,9 @@ public async Task<Result> RecordTransaction(FloatActivityCommands.RecordTransact

FloatActivityAggregate floatActivityAggregate = getFloatActivityResult.Data;

floatActivityAggregate.RecordTransactionAgainstFloat(command.EstateId, getTransactionResult.Data.TransactionDateTime, getTransactionResult.Data.TransactionAmount.GetValueOrDefault(), command.TransactionId);
Result stateResult = floatActivityAggregate.RecordTransactionAgainstFloat(command.EstateId, getTransactionResult.Data.TransactionDateTime, getTransactionResult.Data.TransactionAmount.GetValueOrDefault(), command.TransactionId);
if (stateResult.IsFailed)
return ResultHelpers.CreateFailure(stateResult);

Result saveResult = await this.AggregateService.Save(floatActivityAggregate, cancellationToken);
if (saveResult.IsFailed)
Expand Down
Loading