You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The link to viewdocs.io in README.md should be working now. Also fixed error in install.md - dev-env should be started with npm run watch and not npm watch
You are right. The link is not working. I am sorry that I did not "thoroughly" test before making a pullrequest.
I've taken the pattern on how to link to other docs inside your docs directory from the original viewdocs documentation. If you have a look at the index.md from the original project you can find the line
This page is an example of what documentation will look like by default. Here is [another example page](/viewdocs/example). The source for these pages are in the [docs directory](https://github.com/progrium/viewdocs/tree/master/docs) of the Viewdocs project.
where a working link in the same style is presented that is linking to the example.md page in the docs directory. Instead of /viewdocs/... it should probably be /$project_name/.... Only now it occurs to me that viewdocs is the name of the project. I somehow though "wow. they are going to have magic that makes all the /viewdocs links point to the correct file".
If committed a change where I did exactly that and now it is working as expected.
Yes, the URL path for viewdocs is http://<GITHUB_ACCT>.viewdocs.io/<GITHUB_PROJECT>/.... Yet I still think a relative path starting with ./<PAGE>/ would have been more useful than an absolute one starting with /<GITHUB_PROJECT>/<PAGE>/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The link to viewdocs.io in README.md should be working now. Also fixed error in install.md - dev-env should be started with
npm run watchand notnpm watch