Fixing memory leak in Joint QKV Attention Bridge#1229
Merged
jlarson4 merged 2 commits intodev-3.x-canaryfrom Apr 2, 2026
Merged
Fixing memory leak in Joint QKV Attention Bridge#1229jlarson4 merged 2 commits intodev-3.x-canaryfrom
jlarson4 merged 2 commits intodev-3.x-canaryfrom
Conversation
… in every layer of Joint QKV Attention Bridge
jlarson4
added a commit
that referenced
this pull request
Apr 2, 2026
* Fixing bug with deepcopy that was unintentionally copying all weights in every layer of Joint QKV Attention Bridge * Additional model testing to confirm fix was not negatively impacting models
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#1043 introduced a flaw in the
deepcopyinitially added in #960.Before #1043,
deepcopy(blocks_template)was cheap because the template's submodules didn't hold bound methods referencing the adapter. Oncesplit_qkv_matrixbecame a bound adapter method stored on the attention submodule, the deepcopy started transitively copying the entire adapter (and everything it references) once per attention layer.This affected all architectures that used the
JointQKVAttentionBridgeclass: bloom, neox, pythia, and qwen.The solution was to override
__deepcopy__for the JointQKVAttentionBridge, to ensure that each copy shares a reference to the originalsplit_qkv_matrix&config, rather than creating their own unique copies in memoryType of change
Please delete options that are not relevant.
Checklist: