Skip to content

Fix bug where attributes were being unintentionally dropped#1355

Merged
jlarson4 merged 2 commits into
devfrom
bug/logit_scale_loss
Jun 3, 2026
Merged

Fix bug where attributes were being unintentionally dropped#1355
jlarson4 merged 2 commits into
devfrom
bug/logit_scale_loss

Conversation

@jlarson4
Copy link
Copy Markdown
Collaborator

@jlarson4 jlarson4 commented Jun 3, 2026

Description

Fixed a bug where logit_scale and rope_parameters were not properly propagated through to our TransformerLensConfig

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

@jlarson4 jlarson4 merged commit a865b78 into dev Jun 3, 2026
44 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant