Language Details: Update location display#697
Merged
Conversation
Contributor
Cloudflare Pages previewPreview torn down on PR close: 1 deployment(s) deleted. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Language Details view to improve how location data is presented, including consolidating location mapping UI and adding metadata to distinguish coordinate provenance (Glottolog vs computed/combined).
Changes:
- Updates the Language Details “Location” section to use a single map view with constituent toggling and scope filtering.
- Improves Language Details “Connections” by renaming/ordering constituent lists and adjusting locale filtering/sorting.
- Adds a
coordsSourcefield toLanguageDataand populates it when coordinates come from Glottolog or are computed from constituents.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/widgets/details/sections/LanguageLocation.tsx | Reworks Location UI: coordinate source messaging + consolidated map with constituent controls. |
| src/widgets/details/sections/LanguageConnections.tsx | Adjusts connections display (constituents label, sorting, locale filtering behavior). |
| src/features/transforms/filtering/selectors/LanguageScopeSelector.tsx | Adds optional display prop to control selector presentation. |
| src/features/data/load/extra_entities/GlottologData.tsx | Marks Glottolog-provided coordinates with coordsSource. |
| src/features/data/compute/computeRecursiveLanguageData.ts | Marks computed (averaged) coordinates with coordsSource. |
| src/entities/language/LanguageTypes.ts | Adds coordsSource?: LanguageSource to LanguageData. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #675
Summary: This updates the language details view, in particular the maps shown
Changes
Out of scope/Future work: I would really like auto-zoom but that's a different github issue #678
Test Plan and Screenshots
How to test the changes in this PR: Viewed details for various languages/language families
View when the constituents are off:
