Skip to content

Language Details: Update location display#697

Merged
conradarcturus merged 2 commits into
masterfrom
language-details-location
Jun 27, 2026
Merged

Language Details: Update location display#697
conradarcturus merged 2 commits into
masterfrom
language-details-location

Conversation

@conradarcturus

Copy link
Copy Markdown
Collaborator

Fixes #675

Summary: This updates the language details view, in particular the maps shown

Changes

  • User experience
    • Language Details Location coordinate descriptions updated -- now differentiates between data from Glottolog and data algorithmically combined
    • Language details Location section redone, now combined both maps into 1
      • Fixed filters that may leave out constituents incidentally
      • Will always show the selected entity
      • Default shows all constituents (languages, dialects, ...) but you can turn them off
      • I wasn't sure whether to limit constituents to languages, dialects, etc... so I just put in a scope filter there (if there are nodes to filter)
    • Also made some improvements to the Language Connections section
      • Sorting by the list items by the page source
      • Fixing it so if we are viewing a language family the locales are not filtered in the tree view.
  • Logical changes
    • n/a
  • Data
    • New language field for the source of the coordinates
  • Refactors
    • ...

Out of scope/Future work: I would really like auto-zoom but that's a different github issue #678

Test Plan and Screenshots

How to test the changes in this PR: Viewed details for various languages/language families

Page/View with link Screenshot Before Screenshot After
Sino-Tibetan Screenshot 2026-06-27 at 10 45 10 Screenshot 2026-06-27 at 10 45 18
Chinese Screenshot 2026-06-27 at 10 45 23 Screenshot 2026-06-27 at 10 45 29
French Screenshot 2026-06-27 at 10 45 34 Screenshot 2026-06-27 at 10 45 40

View when the constituents are off:
Screenshot 2026-06-27 at 10 47 40

@github-actions

github-actions Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Cloudflare Pages preview

Preview torn down on PR close: 1 deployment(s) deleted.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Language Details view to improve how location data is presented, including consolidating location mapping UI and adding metadata to distinguish coordinate provenance (Glottolog vs computed/combined).

Changes:

  • Updates the Language Details “Location” section to use a single map view with constituent toggling and scope filtering.
  • Improves Language Details “Connections” by renaming/ordering constituent lists and adjusting locale filtering/sorting.
  • Adds a coordsSource field to LanguageData and populates it when coordinates come from Glottolog or are computed from constituents.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/widgets/details/sections/LanguageLocation.tsx Reworks Location UI: coordinate source messaging + consolidated map with constituent controls.
src/widgets/details/sections/LanguageConnections.tsx Adjusts connections display (constituents label, sorting, locale filtering behavior).
src/features/transforms/filtering/selectors/LanguageScopeSelector.tsx Adds optional display prop to control selector presentation.
src/features/data/load/extra_entities/GlottologData.tsx Marks Glottolog-provided coordinates with coordsSource.
src/features/data/compute/computeRecursiveLanguageData.ts Marks computed (averaged) coordinates with coordsSource.
src/entities/language/LanguageTypes.ts Adds coordsSource?: LanguageSource to LanguageData.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/widgets/details/sections/LanguageLocation.tsx Outdated
Comment thread src/widgets/details/sections/LanguageLocation.tsx Outdated
Comment thread src/widgets/details/sections/LanguageLocation.tsx
Comment thread src/widgets/details/sections/LanguageConnections.tsx Outdated
@conradarcturus conradarcturus merged commit f193f59 into master Jun 27, 2026
8 checks passed
@conradarcturus conradarcturus deleted the language-details-location branch June 27, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UX: Update Location Display Layout in Detailed Language View

2 participants