Fix-Buggy SIRI import in occupancy#1001
Merged
TuThoThai merged 1 commit intoTransmodelEcosystem:v2.0from Mar 5, 2026
Merged
Conversation
The SIRI import is probably coming from a SIRI copy/paste since the NeTEx occupancy is following the SIRI one. The NaturalLanguageStringStructure is not NeTEx type, and is only used in this file, and doesn't follow NeTEx style/rules The SIRI import is crashing some generic NeTEx (and SIRI) import in some implementation (one of them being OpRa). The reason for this crash is difficult to analyse (and depending on the validation engine), but basically related to object redefinition. As a result this import was a useless and dangerous breaking change and has to be removed.
Aurige
added
the
bug
ue71603
approved these changes
Mar 5, 2026
Contributor
TuThoThai
approved these changes
Mar 5, 2026
thbar
approved these changes
Mar 5, 2026
Contributor
thbar
left a comment
thbar
left a comment
There was a problem hiding this comment.
LGTM! I didn't see other similar references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SIRI import is probably coming from a SIRI copy/paste since the NeTEx occupancy is following the SIRI one.
The NaturalLanguageStringStructure is not NeTEx type, and is only used in this file, and doesn't follow NeTEx style/rules. It's replaced with the more "traditional" MultilingualString
The SIRI import is crashing some generic NeTEx import (especially if SIRI is also used) in some implementation (one of them being OpRa). The reason for this crash is difficult to analyse (and is partially depending on the validation engine), but is basically related to object redefinition. As a result this import was a useless and dangerous breaking change and has to be removed.
The SIRI import was there only to allow the use of NaturalLanguageStringStructure and can just be removed.
This is a fix 100% backward compatible at XML Level