FareZone and refs should have constraint checks in timetable XSD#154
Merged
skinkie merged 1 commit intoTransmodelEcosystem:masterfrom Apr 19, 2022
Conversation
This was referenced Feb 10, 2021
skinkie
reviewed
Mar 3, 2021
| </xsd:unique> | ||
| <!-- =====FareZone Key ========================== --> | ||
| <xsd:keyref name="FareZone_KeyRef" refer="netex:FareZone_AnyVersionedKey"> | ||
| <xsd:selector xpath=".//netex:FareZoneRef | .//netex:ParentFareZoneRef | .//netex:FromFareZoneRef | .//netex:ToFareZoneRef |.//netex:ProjectedObjectRef"/> |
Contributor
There was a problem hiding this comment.
Double space after "ToFareZoneRef"
Contributor
|
Was added to new modes branch some time back |
Contributor
|
@nick-knowles please refer to the commit. |
skinkie
reviewed
Apr 13, 2022
| </xsd:unique> | ||
| <!-- =====FareZone Key ========================== --> | ||
| <xsd:keyref name="FareZone_KeyRef" refer="netex:FareZone_AnyVersionedKey"> | ||
| <xsd:selector xpath=".//netex:FareZoneRef | .//netex:ParentFareZoneRef | .//netex:FromFareZoneRef | .//netex:ToFareZoneRef |.//netex:ProjectedObjectRef"/> |
Contributor
There was a problem hiding this comment.
Suggested change
| <xsd:selector xpath=".//netex:FareZoneRef | .//netex:ParentFareZoneRef | .//netex:FromFareZoneRef | .//netex:ToFareZoneRef |.//netex:ProjectedObjectRef"/> | |
| <xsd:selector xpath=".//netex:FareZoneRef | .//netex:ParentFareZoneRef | .//netex:FromFareZoneRef | .//netex:ToFareZoneRef | .//netex:ProjectedObjectRef"/> |
Contributor
They are in NeTEx_publication.xsd but not in NeTEx_publication_timetable.xsd, this pull request is about the latter. |
skinkie
approved these changes
Apr 15, 2022
ue71603
approved these changes
Apr 19, 2022
Aurige
approved these changes
Apr 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As you are allowed to define tariffZones->FareZone in both SiteFrame and ServiceFrame