New modes at# add short name to mobility service#164
Conversation
8 add _mobileAppInstallCheck_ to value to __infoLinkTypes__ enumeration
Align Hire facility values with spec and add values scooterHire, vehicleHire, BoatHire and other. Add parking facility values
|
xsd/netex_framework/netex_utility/tmp0000.xsd |
@nick-knowles I delete this file since it has probably added by mistake to your repository
|
@nick-knowles this PR contains both the shortName change and the previous MobileApp one, I guess that's a branch issue |
|
@Aurige Nick needs to use the new modes as base branch. And create branches from that. If a branch is merged, he pulls the base branch again. |
|
Thanks @skinkie |
Create a new branch, merge the branches you are interested in, continue the work? |
|
Yes, so you create a branch B1, commit+PR1, then create a branch B2 based on branch B1, commit+PR2 ... but then PR2 contains the commits from B1 and B2.... so it's not anymore unitary ! and you get overlaping PRs |
|
You can still merge B1, B2 in that sequence. |
|
Ok, if that's fine for you that's fine for me (I will add this to the doc you started) |
|
@Aurige it does have the implication that if there are changes requested for B1, B2 should be rebased. |
|
is the "git rebase upstream/new-modes B2" the proper one to use for this ? |
I was thinking more in the direction of B1, but after it has been merged, that would make sense. |
As per review meeting 2021.04.14