NewModes - Vehicle charging equipment#223
Merged
Aurige merged 7 commits intoTransmodelEcosystem:new-modesfrom Sep 3, 2021
Merged
NewModes - Vehicle charging equipment#223Aurige merged 7 commits intoTransmodelEcosystem:new-modesfrom
Aurige merged 7 commits intoTransmodelEcosystem:new-modesfrom
Conversation
Country comment from 27.08/2021 Add policy url to Service
Add a PoolOfVehicles Entity as per review meeting, linked to VEHICLEs, MOBILITY SERVICE CONSTRAINT ZONE and PARKING. Extend example to test. Also fix up ReadMe and netex_publication to fix errors introduced by merge on 01 Sep 2021. Also an error had been introduced into access right parameters,
The VDV review comments put forward Vehicle charging elements. to manage the charging of electric vehicles. Adding a charging plan for vehciles needs further modelling so should be left to a future CR. However it is straightforward to add a BatteryEquipment and a ChargingEquipmentProfile based on the VDV values, and incorporating ISOstandard plug types.
Contributor
|
There you have it @nick-knowles. First merge the new-modes branch in your VehicleChargingEquipment branch. Then commit the merge. |
Contributor
@skinkie I updated the README in PR VehicleChargingEquipment branch ... I think it should be Ok now, can you check ? |
Aurige
approved these changes
Sep 3, 2021
Contributor
|
@Aurige This branch is still conflicting... |
Contributor
|
Conflicts should be solved now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VDV review comments put forward Vehicle charging elements. to manage the charging of electric vehicles. Adding a charging plan for vehicles needs further modelling so should be left to a future CR. However it is straightforward to add a BatteryEquipment and a ChargingEquipmentProfile based on the VDV values, and incorporating ISOstandard plug types.