Fix typo and doc of SharpsDisposal#239
Merged
skinkie merged 2 commits intoTransmodelEcosystem:masterfrom Sep 23, 2021
Merged
Conversation
skinkie
added
bug
Contributor
|
Great catch!! |
Contributor
|
I would support an XML example with this PR. |
Contributor
Author
Not sure what you are asking for. |
Contributor
|
You are updating the XSD due to a bug. But if we want to make sure that nobody is affected by such changes in the future, we should make an example using this element that is (automatically) validated prior to merging. |
Aurige
approved these changes
Sep 23, 2021
Contributor
Aurige
left a comment
Aurige
left a comment
There was a problem hiding this comment.
some risks with backwarrd compatibility, but obviously a bug/typo to solve
Contributor
|
@Aurige the quicker they are resolved, the less impact ;) |
skinkie
approved these changes
Sep 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.