Creection_Bug_AccessEquipment#293
Merged
skinkie merged 4 commits intoTransmodelEcosystem:masterfrom Apr 13, 2022
Merged
Conversation
Christophe: It took me forever to understand what as happening with placeEquipments. I finally solved the issue this way <!-- ==ACCESS EQUIPMENT=================================================== --> <xsd:simpleType name="AccessEquipmentIdType"> <xsd:annotation> <xsd:documentation>Type for identifier of an ACCESS EQUIPMENT.</xsd:documentation> </xsd:annotation> <xsd:restriction base="InstalledEquipmentIdType"/> </xsd:simpleType> <!-- <xsd:element name="AccessEquipmentRef" type="AccessEquipmentRefStructure" abstract="true" substitutionGroup="EquipmentRef"> [CD] Since AccessEquipment has InstalledEquipment as substitution group we should have InstalledEquipmentRef here --> <xsd:element name="AccessEquipmentRef" type="AccessEquipmentRefStructure" abstract="true" substitutionGroup="InstalledEquipmentRef"> <xsd:annotation> <xsd:documentation>Identifier of an ACCESS EQUIPMENT.</xsd:documentation> </xsd:annotation> </xsd:element> <xsd:complexType name="AccessEquipmentRefStructure"> <xsd:annotation> <xsd:documentation>Type for a reference to an ACCESS EQUIPMENT.</xsd:documentation> </xsd:annotation> <xsd:simpleContent> <!-- <xsd:restriction base="EquipmentRefStructure"> [CD] Since AccessEquipment has InstalledEquipment as substitution group we should have InstalledEquipmentRef here --> <xsd:restriction base="InstalledEquipmentRefStructure"> <xsd:attribute name="ref" type="AccessEquipmentIdType" use="required"> <xsd:annotation> <xsd:documentation>Identifier of an ACCESS EQUIPMENT.</xsd:documentation> </xsd:annotation> </xsd:attribute> </xsd:restriction> </xsd:simpleContent> </xsd:complexType> It solves the issue.... but this may have some side effect also, can you check how it looks on your side ? We also may need to check if there are other similar issues. If that's Ok, it can be PRed
ue71603
added
the
bug
Contributor
|
Thanks Matthias, |
Aurige
approved these changes
Feb 7, 2022
* CheckConstraint not used * placeEuipment example adapted
Contributor
Author
|
The relevant part of the change was commented out. Now it works... Also added a lot of things from chapter 7 EPIAP so that it is in an example. |
There are fields that are commented, due to the fact that they are in next and not master.
Contributor
Author
Contributor
|
long work, little gain with risks of mistakes ... not really tempted on my side ;-) |
Contributor
The code generation would really benefit from it. (the remove sequences part) |
Contributor
Author
|
...and it is necessary for EPIAP.... |
skinkie
approved these changes
Apr 13, 2022
Merged
erlendnils1
pushed a commit
to entur/NeTEx
that referenced
this pull request
Jun 29, 2023
* Creection_Bug_AccessEquipment There are fields that are commented, due to the fact that they are in next and not master. Co-authored-by: Stefan de Konink <stefan@konink.de>
erlendnils1
pushed a commit
to entur/NeTEx
that referenced
this pull request
Oct 31, 2023
* Creection_Bug_AccessEquipment There are fields that are commented, due to the fact that they are in next and not master. Co-authored-by: Stefan de Konink <stefan@konink.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Christophe: It took me forever to understand what as happening with placeEquipments. I finally solved the issue this way
<xsd:simpleType name="AccessEquipmentIdType">
xsd:annotation
xsd:documentationType for identifier of an ACCESS EQUIPMENT.</xsd:documentation>
</xsd:annotation>
<xsd:restriction base="InstalledEquipmentIdType"/>
</xsd:simpleType>
It solves the issue.... but this may have some side effect also, can you check how it looks on your side ? We also may need to check if there are other similar issues.
If that's Ok, it can be PRed