Conversation
ue71603
added
the
needs documentation update
skinkie
approved these changes
Dec 12, 2023
Contributor
skinkie
left a comment
skinkie
left a comment
There was a problem hiding this comment.
My honest reply: this should not have been put under "stopPlaces". But "stopPlaces" should have been renamed into places.
Contributor
Author
|
@skinkie I can rename it. But I think we need broad approval there @Aurige @nick-knowles |
ue71603
added
the
group_decision_needed
Contributor
Author
|
Details for longer term solution: #609 |
ue71603
commented
Dec 14, 2023
Aurige
approved these changes
Dec 14, 2023
Contributor
Author
|
Do it also in other places where StopPlace_ is mentioned. |
ue71603
removed
the
group_decision_needed
skinkie
approved these changes
Dec 16, 2023
trurlurl
added
document has been updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to fix #512
#512