MultilingualString with embedded translations#849
Merged
Conversation
ue71603
requested review from
Aurige,
JohanEntur,
TuThoThai,
Ulf9,
duexw,
nick-knowles,
skinkie and
trurlurl
ue71603
added
change-request
Aurige
reviewed
Apr 18, 2025
skinkie
reviewed
Apr 18, 2025
skinkie
reviewed
Apr 18, 2025
Co-authored-by: Stefan de Konink <stefan@konink.de>
Co-authored-by: Stefan de Konink <stefan@konink.de>
trurlurl
previously approved these changes
Apr 19, 2025
TuThoThai
reviewed
Apr 21, 2025
ue71603
commented
Apr 22, 2025
Aurige
previously approved these changes
Apr 22, 2025
TuThoThai
previously approved these changes
Apr 22, 2025
ue71603
commented
Apr 22, 2025
Contributor
Author
|
either with text content or content. |
skinkie
previously approved these changes
Apr 22, 2025
Contributor
Author
|
@TuThoThai @Aurige pls review. an example for a simple name can be found in the example as well (but it was there before, so not marked) |
TuThoThai
previously approved these changes
Apr 23, 2025
trurlurl
reviewed
Apr 23, 2025
Contributor
trurlurl
left a comment
trurlurl
left a comment
There was a problem hiding this comment.
Only small improvements / typos - otherwise the description is clear also for me now.
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
trurlurl
approved these changes
Apr 23, 2025
TuThoThai
approved these changes
Apr 23, 2025
trurlurl
added
document has been updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<Name lang="de>blabla</Name>and<Name><Text lang="de">blabla</Text></Name>However, currently sheniganism like
<Name>hurray<Text lang="de">blabla</Text>hiphip</Name>are also possible. Can't be avoided.
And it uses mixed="True" (also probably no way around that)