SeatContext proposal

[TuThoThai]

Addresses both issue #701 and group decision made on 18 March 2025 in PR #813

[Robbendebiene]

I'm still not sure about the arguments against the enum.

Because it is far more difficult to parse.

@skinkie Out of curiosity, what makes it difficult to parse? Since basically every facility is a SomeEnumListOfEnumerations are they hard to parse as well? I can see that boolean properties translate easily into boolean variables of a class but shouldn't a SomeEnumListOfEnumerations also easily translate into a single variable of type List<SomeEnum>?

[Robbendebiene]

Last suggestion from my side 😇
If HasWindowInFront and HasAisleInFront should be kept then perhaps turning them into the same format as the other booleans (IsABC) makes sense to "artificially" group them together?

• HasWindowInFront -> IsFacingWindow or IsBeforeWindow
• HasAisleInFront -> IsFacingAisle or IsBeforeAisle

[skinkie]

@skinkie Out of curiosity, what makes it difficult to parse? Since basically every facility is a SomeEnumListOfEnumerations are they hard to parse as well? I can see that boolean properties translate easily into boolean variables of a class but shouldn't a SomeEnumListOfEnumerations also easily translate into a single variable of type List<SomeEnum>?

The biggest problem is that the changes made by Nick basically combined variants (permutation) in single instances, this is what we are reverting back to direct class attributes. SomeEnumeListOfEnumerations leads to complex queries for OR and AND operators, not directly available without explict parsing and handeling of that list with IN like queries, where the checks have to be explicitly modelled based on the enumeration.

[TuThoThai]

Last suggestion from my side 😇 If HasWindowInFront and HasAisleInFront should be kept then perhaps turning them into the same format as the other booleans (IsABC) makes sense to "artificially" group them together?

* `HasWindowInFront` -> `IsFacingWindow` or `IsBeforeWindow`

* `HasAisleInFront` -> `IsFacingAisle` or `IsBeforeAisle`

Works for me. I likeIsFacingWindow and IsFacingAisle better as they sound clearer to me. Updates on the PR coming!

[skinkie]

@TuThoThai some more validation errors...

[TuThoThai]

@TuThoThai some more validation errors...

@skinkie, apologies... my eyes were clearly not working properly! Thanks for fixing the errors!

[Robbendebiene]

Would it make sense to default all of these properties to false? I'm just asking as I'm not sure if there are any conventions in NeTEx when to use default values and when not.

[skinkie]

@Robbendebiene yes good to mention it. Sane defaults is another issue, better do it directly correct.

[TuThoThai]

@skinkie and @Robbendebiene, default value is now false for all these attributes

[skinkie]

@Robbendebiene yes good to mention it. Sane defaults is another issue, better do it directly correct.

We did the same, but I did not push yet.