Skip to content

Circle CI trigger config#98

Closed
syversenkr wants to merge 2 commits intoTransmodelEcosystem:masterfrom
syversenkr:circleCI_trigger_config
Closed

Circle CI trigger config#98
syversenkr wants to merge 2 commits intoTransmodelEcosystem:masterfrom
syversenkr:circleCI_trigger_config

Conversation

@syversenkr
Copy link
Copy Markdown
Contributor

@syversenkr syversenkr commented Jun 29, 2020

Generalized .circleci/config.yml in regard to hosting config, and additionally documented dependancies to Entur projects (open source)

@skinkie
Copy link
Copy Markdown
Contributor

skinkie commented May 6, 2021

I hope @syversenkr knows what he is doing. I'll approve.

@skinkie skinkie self-assigned this May 6, 2021
@skinkie skinkie added the enhancement non semantic enhacement: technical enhancement, etc. label May 6, 2021
@Aurige
Copy link
Copy Markdown
Contributor

Aurige commented May 7, 2021

I hope @syversenkr knows what he is doing. I'll approve.

Same here ... can you elaborate what this enhancement is doing ?

@syversenkr
Copy link
Copy Markdown
Contributor Author

syversenkr commented May 7, 2021

The confic currently in the master branch was a inadvertent consequence of the previous (last spring) megamerge.

Is really no point in having a Entur specific Circle CI config file in the CEN master repo.

Have for this reason made some adjustments, to make it into a more generic template (currently non-functioning, must be adjusted to local setup) based on the previously included Entur Circle CI config.

This can either be used as a template, if Circle CI based build triggers is relevant at a future stage. If not useful the PR can be retracted, the branch deleted and the .circleci folder + config.yml be deleted from the CEN repo.

Copy link
Copy Markdown
Contributor

@seime seime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this repo is using a different build system, and there is no need for a CircleCI template as well. Should be removed from official repo (and only live inside Entur fork).

@Aurige
Copy link
Copy Markdown
Contributor

Aurige commented Aug 18, 2021

IMHO this repo is using a different build system, and there is no need for a CircleCI template as well. Should be removed from official repo (and only live inside Entur fork).

so we just need to drop .circleci/config.yml from the repo ?

@seime
Copy link
Copy Markdown
Contributor

seime commented Aug 19, 2021

so we just need to drop .circleci/config.yml from the repo ?

Yep

@skinkie
Copy link
Copy Markdown
Contributor

skinkie commented Aug 19, 2021

@seime so don't merge this pull. And remove the file?

@syversenkr
Copy link
Copy Markdown
Contributor Author

@skinkie Yes, delete pull and remove the CircleCI config file and folder

@skinkie skinkie closed this Sep 8, 2021
skinkie added a commit that referenced this pull request Sep 8, 2021
skinkie added a commit that referenced this pull request Sep 8, 2021
@syversenkr syversenkr deleted the circleCI_trigger_config branch September 8, 2021 11:21
skinkie added a commit that referenced this pull request Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement non semantic enhacement: technical enhancement, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants