Circle CI trigger config#98
Conversation
|
I hope @syversenkr knows what he is doing. I'll approve. |
Same here ... can you elaborate what this enhancement is doing ? |
|
The confic currently in the master branch was a inadvertent consequence of the previous (last spring) megamerge. Is really no point in having a Entur specific Circle CI config file in the CEN master repo. Have for this reason made some adjustments, to make it into a more generic template (currently non-functioning, must be adjusted to local setup) based on the previously included Entur Circle CI config. This can either be used as a template, if Circle CI based build triggers is relevant at a future stage. If not useful the PR can be retracted, the branch deleted and the .circleci folder + config.yml be deleted from the CEN repo. |
seime
left a comment
There was a problem hiding this comment.
IMHO this repo is using a different build system, and there is no need for a CircleCI template as well. Should be removed from official repo (and only live inside Entur fork).
so we just need to drop .circleci/config.yml from the repo ? |
Yep |
|
@seime so don't merge this pull. And remove the file? |
|
@skinkie Yes, delete pull and remove the CircleCI config file and folder |
Generalized .circleci/config.yml in regard to hosting config, and additionally documented dependancies to Entur projects (open source)