Added peak hour factor and cascading demand for DAT station capacities.#354
Merged
JamesVaughan merged 1 commit intodevfrom Dec 3, 2025
Merged
Added peak hour factor and cascading demand for DAT station capacities.#354JamesVaughan merged 1 commit intodevfrom
JamesVaughan merged 1 commit intodevfrom
Conversation
In the previous implementations of ComputeStationCapacityFactor each time period was computed independently. This version allows for the additional demand to cascade down between time periods. The order of the time periods is assumed to be the same as the submodule list. This behaviour is off by default to keep backwards compatibility. An additional change is the ability to set the time period peak hour factors. Previously demand was assumed to be in peak period. This option gives more flexibility going forward. The PHF will be divided back out in order to get the period volumes.
amitsandhel
approved these changes
Dec 3, 2025
JamesVaughan
added a commit
that referenced
this pull request
Dec 4, 2025
…s. (#354) In the previous implementations of ComputeStationCapacityFactor each time period was computed independently. This version allows for the additional demand to cascade down between time periods. The order of the time periods is assumed to be the same as the submodule list. This behaviour is off by default to keep backwards compatibility. An additional change is the ability to set the time period peak hour factors. Previously demand was assumed to be in peak period. This option gives more flexibility going forward. The PHF will be divided back out in order to get the period volumes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous implementations of ComputeStationCapacityFactor each time period was computed independently. This version allows for the additional demand to cascade down between time periods. The order of the time periods is assumed to be the same as the submodule list. This behaviour is off
by default to keep backwards compatibility. An additional change is the ability to set the time period peak hour factors. Previously demand was assumed to be in peak period. This option gives more flexibility going forward. The PHF will be divided back out in order to get the period volumes.