Update ash to 0.37.0#109
Closed
BeastLe9enD wants to merge 2 commits intoTraverse-Research:mainfrom
Closed
Conversation
Member
|
Hey, thanks for this! Note that the lint rename should have already been taken care of in #105 (I'll have to check why they were removed instead of renamed in that PR - perhaps we didn't want the lints after all). The ash bump needs some more work before it compiles, we've already done this in #104: feel free to test and review it so that we can merge it and make a new release! |
Author
|
Oh great, I'll do that! |
Member
EmbarkStudios/rust-ecosystem@dc0b264: The lints were made warn-by-default so it wasn't necessary for Embark/us to carry them in our config 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I updated
ashto0.37.0. Also I fixed two lints that were renamed!