Depend on Windows crates only on Windows#93
Merged
manon-traverse merged 1 commit intoTraverse-Research:mainfrom Jan 4, 2022
Merged
Depend on Windows crates only on Windows#93manon-traverse merged 1 commit intoTraverse-Research:mainfrom
manon-traverse merged 1 commit intoTraverse-Research:mainfrom
Conversation
26 tasks
manon-traverse
approved these changes
Jan 4, 2022
Collaborator
manon-traverse
left a comment
manon-traverse
left a comment
There was a problem hiding this comment.
I didn't even realize we were building winapi on Linux and MacOS. It makes a lot more sense to only include it on Windows. Thanks!
Member
|
On non-Windows winapi has a nice |
Contributor
Author
|
Thanks for fast review and merge! Would it be possible to do a patch release of the crate soon that includes this? |
Collaborator
@Jasper-Bekkers Can you do a new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids downloading and depending on the Windows crates when building of other platforms, without impacting Windows support.
Noticed that
gpu-allocatorwas the only dependency that we had that brought inwinapiwhen building our codebase for Mac and Linux, and including it in our licensing summaries and such. This fixes that.