Import Embark clippy lints v5 and fix all fallout#99
Merged
manon-traverse merged 3 commits intomainfrom Feb 25, 2022
Merged
Conversation
…zer` On newer Rust versions the linter now accurately detects fields that are only used in (specific?) `derive` macros like `Debug`, but not anywhere else in the codebase. As such, they should still be considered unused.
MarijnS95
force-pushed
the
unused-field
branch
from
731227b to
406e63d
Compare
MarijnS95
commented
Feb 19, 2022
MarijnS95
changed the title
size field from MemoryBlock
MarijnS95
force-pushed
the
unused-field
branch
from
406e63d to
1173a31
Compare
Jasper-Bekkers
approved these changes
Feb 19, 2022
manon-traverse
approved these changes
Feb 21, 2022
MarijnS95
force-pushed
the
unused-field
branch
from
1173a31 to
9d83f83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On newer Rust versions the linter now accurately detects fields that are only used in (specific?)
derivemacros likeDebug, but not anywhere else in the codebase. As such, they should still be considered unused.