Add per-train lifecycle hook overrides on ServiceTrain#39
Merged
Conversation
Adds protected virtual OnStarted, OnCompleted, OnFailed, and OnCancelled methods to ServiceTrain. Individual trains can override these to react to their own lifecycle events without registering a global ITrainLifecycleHook. Global hooks fire first, then train-level overrides. Exceptions in overrides are caught and logged, matching the global hook error handling pattern.
…kFactory AddLifecycleHook<T>() now accepts either ITrainLifecycleHook or ITrainLifecycleHookFactory directly. When given a hook type, a generic LifecycleHookFactory<T> is created internally — no need for hand-written factory classes. Removes BroadcastLifecycleHookFactory in favor of the generic factory.
|
This PR is included in version 1.24.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
protected virtualOnStarted, OnCompleted, OnFailed, and OnCancelled methods toServiceTrainso individual trains can override them without registering a globalITrainLifecycleHookTest plan
TrainLifecycleOverrideTestspass (InMemory provider)LifecycleHookRunnerTestsandAddLifecycleHookTestsstill pass