Fix circular test deps, add benchmarks#6
Merged
Merged
Conversation
- Removed Postgres and MemoryLeak integration tests (moved to Trax.Mediator where they can use ProjectReference to Mediator instead of PackageReference) - Added benchmarks project (moved from Trax.Core where it had a circular PackageReference to Trax.Effect) - Updated solution file accordingly
|
This PR is included in version 1.1.0 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trax.Effect.Tests.Data.Postgres.Integration(moved to Trax.Mediator)Trax.Effect.Tests.MemoryLeak.Integration(moved to Trax.Mediator)Trax.Effect.Tests.Benchmarks(moved from Trax.Core)Both Postgres and MemoryLeak tests had circular PackageReferences to Trax.Mediator
(which depends on Effect). In Trax.Mediator they can use ProjectReferences instead.
The benchmarks had a circular PackageReference to Trax.Effect from Trax.Core.
Here they can use ProjectReferences to Effect sub-projects.
Test plan