fix: add typed outputs to sample trains#12
Merged
Conversation
Update ProcessMatchResultTrain, RecalculateLeaderboardTrain, GenerateSeasonReportTrain, and LookupPlayerTrain to return typed output records instead of Unit, demonstrating the scheduler's support for non-Unit output types on the dashboard.
Theauxm
force-pushed
the
fix/remove-unit-output-constraint
branch
from
c50b159 to
1b1e4cc
Compare
Update sample projects to match Trax.Scheduler rename.
Update all sample Program.cs files to use services.AddTrax(trax => trax.AddEffects(...).AddMediator(...).AddScheduler(...)) pattern. Restructure sample directory layout.
Prevents accidental resolution of unlisted 2.x packages from nuget.org by constraining cross-repo PackageReference to 1.* range.
|
This PR is included in version 1.7.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unit:ProcessMatchResultTrain→ProcessMatchResultOutput(ELO changes, anomaly count)RecalculateLeaderboardTrain→RecalculateLeaderboardOutput(player count, top player)GenerateSeasonReportTrain→SeasonReportOutput(report ID, match/player counts)LookupPlayerTrain→PlayerProfile(rank, wins, losses, rating)Test plan
dotnet buildsucceeds with zero errors