Clean up TestRunner and add lifecycle hook examples#28
Merged
Conversation
Simplify TestProjectRegistry to scan a single tests/ directory instead of assuming monorepo structure. Drop RepoName and RequiresPostgres from TestProject since the sample doesn't use them. Rename ScanMonorepoJunction to ScanProjectsJunction and trim unused fields from the React client.
Add AuditLogHook as a global ITrainLifecycleHook that logs train completion and failure events. Register it in both API and Scheduler Program.cs via AddLifecycleHook<AuditLogHook>(). Also add per-train hook overrides in BanPlayerTrain to show both approaches side by side.
|
This PR is included in version 1.17.1 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RepoName/RequiresPostgresfrom the model, simplifyTestProjectRegistryto scan a singletests/directory, renameScanMonorepoJunction→ScanProjectsJunction, trim unused fields from the React clientAuditLogHookas a globalITrainLifecycleHookin the GameServer sample, registered in both API and Scheduler viaAddLifecycleHook<AuditLogHook>()OnCompleted/OnFailedoverrides inBanPlayerTrainto demonstrate both hook approaches side by sideSalvaged from the unmerged tail of
feat/testrunner-sample(PR #27), rebased cleanly onto current main.