feat: opt samples into operations namespace where their UIs need it#45
Merged
feat: opt samples into operations namespace where their UIs need it#45
Conversation
…need it
The operations namespace is opt-in as of Trax.Api 1.x. Samples whose
UIs and E2E tests rely on operations.{health, manifests, executions,
deadLetters, triggerManifest, ...} now opt in explicitly:
- GameServer.Api: web UI ops dashboard + trigger/cancel from the page
- EnergyHub.Hub: Next.js web UI manifest dashboard
- JobHunt.Hub: phase-0 schema sanity test relies on ops being present
Other samples already register [TraxQuery]/[TraxMutation] trains so
their schemas have non-empty Query/Mutation roots without operations.
|
This PR is included in version 1.21.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
operationsGraphQL namespace becomes opt-in in Trax.Api PR #35. Samples whose UIs and E2E tests rely onoperations.{health, manifests, executions, deadLetters, triggerManifest, ...}now opt in explicitly.GameServer.Api(web UI ops dashboard + trigger/cancel from the page),EnergyHub.Hub(Next.js manifest dashboard),JobHunt.Hub(phase-0 schema sanity test relies on framework-level fields being present).[TraxQuery]/[TraxMutation]trains so their schemas have non-empty Query/Mutation roots without operations.Test plan
dotnet buildclean across all sample projects.:5432; currently held by an unrelated container in my env).GameServer.Apiweb UI and confirm the ops dashboard renders.