Conversation
…rcuit/AddServices names)
|
This PR is included in version 1.21.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
50 sample trains migrated to the new
Junctions()shape from Trax.Core. Mechanical edit: return type wraps inTask<Either<Exception, ...>>, body appends.Resolve(), addsusing LanguageExt;where missing.Sample apps (
GameServer,EnergyHub,ChatService,JobHunt,ContentShield,Flowthru.Spaceflights,TestRunner,ApiAudit) all build clean and most test suites pass.Test plan
dotnet csharpier check .passesTrax.Samples.GameServer.E2Ethat look unrelated to the chain refactor — calling out for visibility:BanPlayer_WithAdminKey_SucceedsandBanPlayer_RunMutation_ExecutesInlinefail withNot authorizeddespite the admin key carrying bothAdminandPlayerroles. The inverse test (BanPlayer_WithPlayerKey_Returns403) passes, so the auth pipeline reaches the right verdict on the deny path. The auth packages have no chain code (grep -rn "Chain\|Junctions\|Resolve" Trax.Api.Auth* → 0 hits).OnTrainStarted_ReceivesEvent,OnTrainCompleted_ReceivesEvent,OnTrainFailed_NoEventForNonBroadcastTrainall fail atWebSocketClient.ConnectAsyncwithIncomplete handshake, status code: 200— TestHost is returning 200 instead of 101 on the WS upgrade. Independent of the chain.Migration
See Trax.Docs migration guide for the consumer-facing pattern.