test: pin Postgres pool size in E2E factories#49
Merged
Conversation
|
This PR is included in version 1.21.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JobHunt/GameServer/EnergyHub E2E factories had
Maximum Pool Size=10but no idle pruning. Each test instantiates a freshWebApplicationFactory, which gets its own pool, so over a long suite Postgres'max_connectionsgets exhausted in CI (saw 30 JobHunt E2E tests fail withNpgsql.NpgsqlException: The operation has timed outon the latest release run).Drops pool size to 4 and adds
Connection Idle Lifetime=1+Connection Pruning Interval=1so connections don't pile up between hosts. Same fix used in Trax.Api and Trax.Scheduler for the same root cause.Test plan