Skip to content

Remove unreachable /test/testParser.html URL mapping and associated dead JSP files#424

Merged
rvosa merged 5 commits intomasterfrom
copilot/analyze-testparser-usage
Feb 19, 2026
Merged

Remove unreachable /test/testParser.html URL mapping and associated dead JSP files#424
rvosa merged 5 commits intomasterfrom
copilot/analyze-testparser-usage

Conversation

Copy link
Contributor

Copilot AI commented Feb 19, 2026

  • Investigate the /test/testParser.html mapping in treebase-servlet.xml
  • Remove <prop key="/test/testParser.html">treeParserController</prop> from treebase-servlet.xml (2-line removal, no other changes)
  • Remove the legacy testParser.jsp file (only redirected to /user/treeParser.html)
  • Remove the legacy testParserResult.jsp file (not referenced anywhere)
  • Fix CI workflow: abort rebase before force-pushing to gh-pages when concurrent deployment conflicts occur

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: rvosa <106490+rvosa@users.noreply.github.com>
Copilot AI changed the title [WIP] Investigate usage and necessity of testParser.html Remove unreachable /test/testParser.html URL mapping and associated dead JSP files Feb 19, 2026
Copilot AI requested a review from rvosa February 19, 2026 18:18
@rvosa
Copy link
Contributor

rvosa commented Feb 19, 2026

@copilot the CI/CD is failing and I think it is simply because you need to rebase the branch or something. Fix this.

Co-authored-by: rvosa <106490+rvosa@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 19, 2026

@copilot the CI/CD is failing and I think it is simply because you need to rebase the branch or something. Fix this.

The CI failure (run #22194338358) wasn't a branch sync issue — the build and tests passed fine. The failure was in the "Commit and push to gh-pages" deployment step: when git pull --rebase failed due to a concurrent CI run also pushing to that branch, the || fallback tried git push --force while git was still mid-rebase, which also failed. Fixed in 52d7a50 by adding git rebase --abort before the force push, which cleans up the broken rebase state first.

@rvosa
Copy link
Contributor

rvosa commented Feb 19, 2026

@copilot why are there so many diffs in treebase-servlet.xml right now when you are just removing a couple of things. Are you reformatting stuff? Don't do that, it makes it impossible for me to review. Just remove the testParser prop from the XML, the JSP files you were going to remove, and do the update to the CI. Keep the edits in the XML to a minimum otherwise.

Co-authored-by: rvosa <106490+rvosa@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 19, 2026

@copilot why are there so many diffs in treebase-servlet.xml right now when you are just removing a couple of things. Are you reformatting stuff? Don't do that, it makes it impossibl...

Fixed in 530a317. The merge of master into the branch had caused a large whitespace diff in treebase-servlet.xml. I've reset the file to the master version and applied only the 2-line removal of the testParser prop — the diff is now exactly that and nothing else.

@rvosa rvosa marked this pull request as ready for review February 19, 2026 18:51
@rvosa rvosa merged commit 6d50a01 into master Feb 19, 2026
3 checks passed
@rvosa rvosa deleted the copilot/analyze-testparser-usage branch February 19, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments