Test harness and integration tests#138
Open
sastraxi wants to merge 12 commits intoTreeFallSound:pistomp-v3from
Open
Test harness and integration tests#138sastraxi wants to merge 12 commits intoTreeFallSound:pistomp-v3from
sastraxi wants to merge 12 commits intoTreeFallSound:pistomp-v3from
Conversation
Positional unpacks break every time a new field is added. A dataclass allows attribute access so field additions never require mechanical fixes across test files. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Mechanical follow-up to the NamedTuple → dataclass conversion. Every unpack site across all test files now uses named attribute access, so future field additions to SystemFixture require no changes here. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
# Conflicts: # uv.lock
sastraxi
commented
May 9, 2026
| @@ -0,0 +1,27 @@ | |||
| name: Tests | |||
Contributor
Author
There was a problem hiding this comment.
Caveat emptor: I have not tested this script.
sastraxi
commented
May 9, 2026
sastraxi
commented
May 9, 2026
# Conflicts: # modalapi/modhandler.py # pistomp/hardware.py # pyproject.toml # uv.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on top of some of the PIL fixes, I played around today with an integration test harness:
data_diras a parameter to ModHandler so we can isolate testsHad to download the ttfs and put them in the dir to make the suite portable.
Branch stack