Refactor: footswitch init and add tests#143
Merged
rreichenbach merged 8 commits intoMay 21, 2026
Merged
Conversation
rreichenbach
approved these changes
May 21, 2026
Collaborator
rreichenbach
left a comment
There was a problem hiding this comment.
This looks good and seems to work well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
Footswitch.enabledtotoggledthroughout the codebase. The old name was misleading as it tracked the toggle state of the switch (on/off), not whether the switch itself was enabled.Disambiguating this frees us up to do the following:
disable: truealready suppresses a footswitch for a given pedalboard; we now save its current value in the Footswitch objectlongpresson an encoder now works the same way it already did on footswitches — pedalboard config can override the default callback, and an explicit null clears it. Required threading encoder GPIO switches through a new encoder_switch_map keyed by config id, populated by pistomptre at init.Tests in tests/v3/test_hardware_config.py cover both the existing footswitch overlay behaviour (longpress set/override/reset/suppress, color persistence) and the new encoder + disable paths.
The pistompcore encoder init still hardcodes a single switch; added a brief XXX comment about it.