Footswitch bugfixes#178
Merged
sastraxi merged 12 commits intoJul 3, 2026
Merged
Conversation
Erase the previously drawn keycap on single-widget refresh so a narrower label no longer leaves ghost pixels from a wider one, giving a consistent black backdrop. Track the keycap footprint slot-relative so the erase never touches a neighbouring switch. Make drives_display true for non-:bypass param bindings: only :bypass gets a WS bypass-echo redraw, so footswitches bound to other params (e.g. mixer Solo) must update their own LED/LCD on press. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…n-bypass initial state
sastraxi
force-pushed
the
feat/simple-footswitch-ui
branch
from
e73e18d to
572cb14
Compare
sastraxi
changed the title
rreichenbach
approved these changes
Jul 3, 2026
rreichenbach
left a comment
rreichenbach
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, works well
sastraxi
force-pushed
the
feat/simple-footswitch-ui
branch
from
640d04a to
572cb14
Compare
# Conflicts: # pistomp/footswitch.py # tests/test_footswitch.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks the LCD footswitch strip (on v3) so stays in sync with MOD-UI and behaves consistently whether it is bound to a bypass or to an arbitrary parameter.
What changed
:bypassnow derives its on/off state directly from the parameter value, without the bypass inversion. This means toggle parameters like a "Solo" switch light up exactly when MOD-UI says they are on, rather than silently staying constant.