Fix the return tuples for parse_break_cmd#29
Merged
rocky merged 1 commit intoTrepan-Debuggers:masterfrom Dec 19, 2020
Merged
Conversation
looks like a couple of modules were missed when you added the offset to the returned tuple for parse_break_cmd the returned tuples in continue.py and tbreak.py are misssing offset the returned tuples in break.py and line.py are ok. causes commands like "c 20" to fail when I use trepan3k 1.2.0
Contributor
Author
|
Looks like appveyor failed again. Hopefully the proposed fix makes sense and you can just add an equivalent commit on your own branch and bypass whatever problems I created. |
Collaborator
|
Thanks. As for appveyor, it is probably bitrot. I'll address that separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
looks like a couple of modules were missed when you added the offset
to the returned tuple for parse_break_cmd
the returned tuples in continue.py and tbreak.py are misssing offset
the returned tuples in break.py and line.py are ok.
causes commands like "c 20" to fail when I use trepan3k 1.2.0
(I tried to minimize code changes, so I didn't try to make it DRY)