fix: at glob/glob in glob.c#186
Merged
rocky merged 1 commit intoMay 16, 2026
Merged
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
glob/glob.c.Vulnerability
V-001glob/glob.c:401Description: At glob/glob.c:401, the buffer 'onealt' is allocated as strlen(pattern)-1 bytes. At line 414, memcpy copies 'begin - pattern' bytes from 'pattern' into 'onealt' without verifying that the copy length fits within the allocated buffer. A crafted alternation pattern where the prefix before the opening brace is longer than strlen(pattern)-1 causes a heap buffer overflow. Lines 472-473 compound this by copying additional data (next-p bytes plus rest_len bytes) into alt_start derived from onealt without any bounds validation, potentially overflowing the same buffer a second time.
Changes
glob/glob.cVerification
Automated security fix by OrbisAI Security