Skip to content
This repository was archived by the owner on Feb 1, 2026. It is now read-only.

feat: add index routes pages#215

Merged
JaimeTorrealba merged 6 commits intomainfrom
feature/add-index-routes-pages
Sep 28, 2023
Merged

feat: add index routes pages#215
JaimeTorrealba merged 6 commits intomainfrom
feature/add-index-routes-pages

Conversation

@JaimeTorrealba
Copy link
Copy Markdown
Member

Little PR to add the routes in the index page

(the CSS is very simple, I'm not good using UnoCSS) Any help appreciated

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 17, 2023

Deploy Preview for cientos-tresjs ready!

Name Link
🔨 Latest commit f817cde
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/6514edcbb3213e000831b74b
😎 Deploy Preview https://deploy-preview-215--cientos-tresjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JaimeTorrealba JaimeTorrealba marked this pull request as ready for review September 18, 2023 16:04
@JaimeTorrealba
Copy link
Copy Markdown
Member Author

@andretchen0 would you like to tweak a little, this one? Basically just add some styles?

@andretchen0
Copy link
Copy Markdown
Contributor

@JaimeTorrealba

Sure thing. I don't know much about Uno either, but I'll see what I can do.

@andretchen0
Copy link
Copy Markdown
Contributor

andretchen0 commented Sep 26, 2023

Basically just add some styles?

Since you mentioned Uno:

Looking at the playground directory, Uno isn't included. Vitepress is also not included. That means we can't easily use the same styles from the docs site, as far as I can tell.

  • Do we want to add Uno or VitePress?
  • Or should we just add some plain CSS styles?

@JaimeTorrealba
Copy link
Copy Markdown
Member Author

JaimeTorrealba commented Sep 27, 2023

Hi, For this issue please be creative, what I did just work, but is ... ugly hahaha

I don't understand well how this work, Uno seems not being installed but some "tailwinish" styles are available (I don't work with tailwind) dunno what configuration did Alvaro regarding the styles.

Anyway plain CSS is fine for me, this is just for improving a little the DX Feel free to ve creative with this one

@andretchen0
Copy link
Copy Markdown
Contributor

andretchen0 commented Sep 28, 2023

Looks like there was a version of Uno in there. I used Tailwind-type styles to format the landing page to look like the other Cientos/TresJS pages. I didn't create a dark mode – though that would be nice!

There was a conflict with the styles required by full-page THREE components. The styles in /playground/src/style.css made the landing page always show a scrollbar. So I created an override using the route name "Home" as a class on the body.

While I was at it, I added the route name to the document title (the one shown in the browser chrome).

@JaimeTorrealba
Copy link
Copy Markdown
Member Author

I love the final result, thanks for this @andretchen0

@JaimeTorrealba JaimeTorrealba merged commit 9bb0f4a into main Sep 28, 2023
@andretchen0 andretchen0 deleted the feature/add-index-routes-pages branch September 28, 2023 13:01
@andretchen0 andretchen0 restored the feature/add-index-routes-pages branch September 28, 2023 13:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants