Skip to content
This repository was archived by the owner on Feb 1, 2026. It is now read-only.

docs(Lensflare): add demo#232

Merged
alvarosabu merged 8 commits intomainfrom
docs/lensflaredemo
Oct 9, 2023
Merged

docs(Lensflare): add demo#232
alvarosabu merged 8 commits intomainfrom
docs/lensflaredemo

Conversation

@andretchen0
Copy link
Copy Markdown
Contributor

@andretchen0 andretchen0 commented Sep 23, 2023

This adds a demo to the Lensflare docs page.

It also updates the "Usage" example. It's now a working SFC.

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 23, 2023

Deploy Preview for cientos-tresjs ready!

Name Link
🔨 Latest commit 369e992
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/65241a025737270008cac2fc
😎 Deploy Preview https://deploy-preview-232--cientos-tresjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andretchen0 andretchen0 marked this pull request as ready for review September 23, 2023 00:35
Copy link
Copy Markdown
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks awesome @andretchen0. I would probably use a darker clear color for the canvas, the teal one does not necessarily provide justice to the effect. 😅

Did you consider adding a GUI with tresleches for the scale?

@andretchen0
Copy link
Copy Markdown
Contributor Author

Good call on the color.

Did you consider adding a GUI with tresleches for the scale?

I hadn't considered it for the docs demo – mostly just because Lensflare has a lot of props.

It's no problem though. Would you like me to add a scale control?


There's another demo that includes most of the props as Leches controls – including scale – that I was going to add to the playground. In the cientos repo, if you run ...

pnpm run playground

... you can see the demo at:

http://localhost:5173/abstractions/lensflare

@alvarosabu
Copy link
Copy Markdown
Member

Oh yeah @andretchen0 the demo in the playground is the one I used for the video on the announcement. I think it would be cool to add the scale control for the docs demo.

@andretchen0
Copy link
Copy Markdown
Contributor Author

andretchen0 commented Sep 27, 2023

@alvarosabu

I've added a Leches controller for the scale, following the example at:

/guide/controls/transform-controls.html

I added small CSS important rule to stick the Leches window to the top, after I noticed this behavior:

Screen.Recording.2023-09-27.at.19.56.10.mov

Should I open a Leches issue, or is there a "blessed" way to handle that?

@andretchen0 andretchen0 requested a review from alvarosabu October 4, 2023 01:45
@alvarosabu
Copy link
Copy Markdown
Member

@alvarosabu

I've added a Leches controller for the scale, following the example at:

/guide/controls/transform-controls.html

I added small CSS important rule to stick the Leches window to the top, after I noticed this behavior:

Screen.Recording.2023-09-27.at.19.56.10.mov
Should I open a Leches issue, or is there a "blessed" way to handle that?

The CSS important will collide with the draggable, that's why is fixed. Maybe we should add an option to place it (left, right, top, bottom 🤔)

Copy link
Copy Markdown
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andretchen0 nice work with the demo, just solve the latest conflicts with the main and we are ready to merge

@andretchen0
Copy link
Copy Markdown
Contributor Author

@andretchen0 nice work with the demo, just solve the latest conflicts with the main and we are ready to merge

Ok, I've merged in main. I think it's ready to go.

@andretchen0 andretchen0 requested a review from alvarosabu October 9, 2023 15:21
@alvarosabu alvarosabu merged commit 20dc1bb into main Oct 9, 2023
@andretchen0 andretchen0 deleted the docs/lensflaredemo branch October 9, 2023 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants