docs: import demos#245
Conversation
✅ Deploy Preview for cientos-tresjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JaimeTorrealba
left a comment
There was a problem hiding this comment.
Thank you so much for this PR, solutions like this help us to scale more
I know is not specially fun but avoid a lot of typos problems
🙏🏼
|
And don't worry about the moment, we can use the '<<< @/.vitepress' Format. This is already a great DX change for us. We could always go back to this later |
|
I approved already, but before merge, let me know when you delete the .d.ts file please |
I don't mind. It's better than trying to keep a copy of the demos in sync. The next big missing piece for me is the props section of the docs. It'd really be great if those tables could be pulled from the components. I think most of the component have JSDocs for the props. Ideas are welcome! 😀 |
|
Yes, as you can see we're a small numbers of maintainers here, a cientos was basically maintained just by me (Alvaro helps a lot, but he has other pkgs too, and Tino is full focus on the post-processing pkg) So your addition is really appreciated, we could talk about how improve the pkg and the DX (not only do components) Also, about another pkg for the ecosystem, I send to you a discussion in Discord about other future pkg If you want, I'm available for discussing more on discord :) |
This closes #242 .
<TresCanvas v-bind="gl" />andglobject and replacing it with<TresCanvas clear-color="#333">, or removing refs. I don't think that's noticeable for the most part, but let me know if I went too far.BackdropDemo.vueis one instance. (Note that it is possible to include a VSCode-style region, but I didn't want to complicate things. Only whole files are imported at the moment.).vuedemo files, not in the.mdfiles. That's possible with the current system. But when the.vuefiles are parsed for rendering, they throw an error if used within a Vue component, e.g.:Highlighting a component over multiple lines is a really common case for us. Since that breaks the demos, to keep things consistent, I left all highlighting in the
.mdfiles. That looks like this:Above the lines 2, 6, 19, and 28 are highlighted.