Conversation
✅ Deploy Preview for tresjs-labs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…gic and console logs
alvarosabu
added a commit
that referenced
this pull request
Sep 21, 2025
* chore: refactor project structure and update configurations WIP - Removed .eslintrc.json in favor of a new eslint.config.mjs for better integration with Nuxt. - Updated .gitignore to include .data directory. - Cleaned up .npmrc by removing unnecessary configurations. - Added app.config.ts for UI configuration. - Replaced TheToolbar component with TheHeader for improved layout in default.vue. - Updated index.vue to enhance experiment data fetching and presentation. - Introduced new types for Experiment and Author items in types/index.ts. - Added multiple new content files and images for experiments. - Updated main.css to include new theme variables and styles. - Removed unused components and files to streamline the project. This commit enhances the overall structure and maintainability of the project. * feat: update configurations and enhance component structure - Updated app.config.ts to improve card styling with new utility classes. - Modified package.json to point @Tresjs/cientos to a specific commit and upgraded @Tresjs/core to the next version. - Adjusted pnpm-lock.yaml to reflect the updated dependencies. - Refactored TheCard component to utilize a more structured props interface and improved rendering logic. - Enhanced the layout in default.vue to include a background pattern for better visual appeal. - Updated [...slug].vue to streamline data fetching and improve SEO metadata handling. - Replaced the experiment card rendering in index.vue with a more reusable TheCard component. - Improved the Ritual and Lamb components to utilize computed properties for better performance and readability. These changes enhance the overall maintainability and visual consistency of the project. * refactor: cult-of-the-lamb ritual component * feat: update dependencies and enhance Brownian distribution component - Upgraded @Tresjs/core to version 5.0.0-next.5 in package.json and updated pnpm-lock.yaml to reflect the changes. - Introduced a new BrownianDistributionGroupInstances component to implement Brownian motion with instanced meshes. - Refactored existing components to improve performance and readability, including the KnightRigged and David components. - Enhanced the brownian-distribution experiment with a new markdown file and an accompanying image. - Updated the layout in default.vue for better structure and visual consistency. These changes improve the overall functionality and maintainability of the project while introducing new features for the Brownian distribution experiment. * fix: enhance card styling in app.config.ts - Updated the root slot style in app.config.ts to include rounded corners for improved visual appeal. - This change enhances the overall user interface by providing a more polished look to the card component. * feat: enhance app layout and update dependencies - Refactored app.vue to include a new UMain wrapper for improved layout structure. - Integrated useAsyncData for navigation and files, enhancing data fetching capabilities. - Updated nuxt.config.ts to switch from @nuxt/ui to @nuxt/ui-pro for better UI components. - Modified TheCodeButton.vue to utilize UButton for a more consistent button design. - Refactored TheHeader.vue to use UHeader and UColorModeButton for improved header functionality. - Enhanced the dark mode toggle button in the brownian-distribution component for better UX. - Updated main.css to reflect the change to @nuxt/ui-pro. These changes improve the overall user experience and maintainability of the project. * feat: refactor synthwave landscape components and improve rendering logic - Introduced a new `onLoop` function in `index.vue` to handle rendering updates more cleanly. - Updated `TresCanvas` to utilize the new `onLoop` method for better performance. - Refactored `Grid`, `Mountain`, `Sun`, `Terrain`, and `GradientSky` components for improved readability and consistency. - Replaced imports from `three/examples` with `three-stdlib` for better compatibility and maintainability. - Enhanced `MusicPlayer` component by using `MathUtils.clamp` for improved functionality. - Added a new markdown file and image for the synthwave landscape experiment to enhance documentation. These changes improve the overall structure, performance, and maintainability of the synthwave landscape components. * feat: update low poly planet components and enhance rendering logic - Refactored `Airplane.vue` and `Cloud.vue` to utilize computed properties for better reactivity and performance. - Updated the `Planet.vue` component to ensure proper shadow handling and added a reference for the planet object. - Enhanced the `index.vue` layout by integrating `TresCanvas` with improved shadow settings and added `Stars` for visual enhancement. - Introduced a new markdown file and image for the low poly planet experiment to improve documentation. These changes enhance the overall structure, performance, and maintainability of the low poly planet components. * fix: update dependencies for @Tresjs packages - Updated the version of `@tresjs/post-processing` to `3.0.0-next.0`, `@Tresjs/cientos` to `5.0.0-next.3`, and `@Tresjs/core` to `5.0.0-next.6` in `package.json` and reflected these changes in `pnpm-lock.yaml`. - These updates ensure compatibility with the latest features and improvements in the TresJS ecosystem, enhancing overall project stability and performance. * feat: enhance David component with loading readiness and rendering logic - Introduced an emit event for 'ready' in the David component to signal when the model is fully loaded and ready for rendering. - Updated the rendering condition in the template to use the new `isReady` state, ensuring the `brickInstancedMesh` is only displayed when ready. - Added a new `onDavidReady` method in the index.vue to handle camera positioning once the David model is ready, improving the overall user experience and interaction flow. These changes enhance the responsiveness and interactivity of the David component within the scene. * feat: update author handling and enhance component structure - Modified the author field in content.config.ts to support both single and multiple authors using a union type. - Refactored TheCard.vue to accommodate an array of authors, improving the display logic for author information. - Updated synthwave-landscape experiment markdown files to reflect multiple authors. - Enhanced data fetching in index.vue to handle multiple authors correctly, ensuring proper rendering and data integrity. These changes improve the flexibility and maintainability of author data handling across the application. * chore: update glass material * chore: threejs journey portal * fix: update SEO metadata and enhance TheCard component interaction - Updated the SEO metadata in app.vue to set a static title and site name for improved search engine visibility. - Modified TheCard.vue to prevent event propagation on button click, enhancing user interaction and preventing unintended behavior. - Added meta description in index.vue to provide context for the TresJS Lab, improving discoverability. These changes enhance the overall user experience and SEO performance of the application. * fix: update date in portal journey markdown - Changed the date in the portal journey markdown file from 2023-12-08 to 2023-03-27 to reflect the correct timeline of the content. This update ensures the accuracy of the metadata associated with the portal journey documentation. * feat: phone html with tresjs next website * feat: refactor Nuxt Stones component and enhance rendering logic - Updated the `index.vue` file to simplify the TresCanvas properties and improve the structure of the rendering logic. - Refactored the `Stones.vue` component to utilize computed properties for better reactivity and manage texture flipping with watchers. - Introduced a new markdown file and image for the Nuxt Stones experiment to enhance documentation and provide context for the scene. These changes improve the overall performance, maintainability, and documentation of the Nuxt Stones component. * feat: refactor potions classroom components for improved reactivity and performance - Updated multiple components in the potions classroom to utilize computed properties and watchers for better reactivity, including `Books.vue`, `Bottles.vue`, `Bricks.vue`, `Cauldron.vue`, and others. - Removed unnecessary `await` from `useGLTF` calls to ensure reactive references are maintained. - Enhanced material application logic by using computed properties and watchers to dynamically update materials based on texture changes. - Improved template rendering with conditional checks to ensure nodes are available before rendering, enhancing performance and preventing potential errors. - Added a new markdown file and image for the potions classroom experiment to enhance documentation and provide context for the scene. These changes significantly improve the maintainability, performance, and documentation of the potions classroom components. * feat: update repulsion effect component and enhance documentation - Refactored the `index.vue` and `scene.vue` files for the Repulsion Effect component to improve structure and performance, including the removal of unnecessary variables and the use of TypeScript for type safety. - Simplified the geometry and material handling by utilizing a geometry map and a shared material for better maintainability. - Updated the linting command in `package.json` to streamline the linting process. - Added a new markdown file and image for the Repulsion Effect experiment to enhance documentation and provide context for the scene. These changes improve the overall performance, maintainability, and documentation of the Repulsion Effect component. * refactor: streamline imports and enhance component structure in ShaderToy museum - Updated multiple components in the ShaderToy museum to use type imports for better clarity and performance, including `Camera.vue`, `Gallery.vue`, `Lights.vue`, `ShaderToy.vue`, and `TextUi.vue`. - Simplified the import statements by separating type imports from regular imports, improving readability. - Adjusted the `TresCanvas` component usage in `index.vue` for better event handling. - Enhanced the `glNosie.ts` file by updating GLSL code for better maintainability and clarity. These changes improve the overall structure, readability, and performance of the ShaderToy museum components. * feat: enhance particle pumpkin component structure and improve code readability - Refactored `Credits.vue`, `index.vue`, and `Pumpkin.vue` components to streamline the template structure and improve readability by consolidating class attributes. - Removed unnecessary comments and imports in `Pumpkin.vue` to clean up the code. - Introduced computed properties and watchers for better reactivity in `Pumpkin.vue`, ensuring dynamic updates to the pumpkin geometry and points. - Added a new markdown file and image for the Particle Pumpkin experiment to enhance documentation and provide context for the scene. These changes improve the overall maintainability, performance, and documentation of the Particle Pumpkin components. * chore: update and rework magical marbles (#259) * chore: update magical-marbles * chore: update magical-marbles template * chore: update Tres.js dependencies and clean up Nuxt configuration - Removed `@tresjs/leches/styles` from the Nuxt configuration to streamline CSS imports. - Updated the `@tresjs/leches` dependency to a newer version in `package.json` and `pnpm-lock.yaml` for improved functionality and performance. - Cleaned up unused components related to GitHub stars and materials to enhance project maintainability. These changes improve the overall structure and performance of the project. --------- Co-authored-by: alvarosabu <alvaro.saburido@gmail.com> * feat: add BlobPermissionModal and enhance dancing blob component - Introduced `BlobPermissionModal.vue` to handle microphone permission requests with a user-friendly modal. - Updated `index.vue` in the dancing blob component to utilize VueUse composables for microphone permission management and integrated the new modal for user interaction. - Enhanced `TheDancingBlob.vue` to include controls for wireframe, color gradients, and amplitude adjustments, improving visual customization. - Updated fragment shader to dynamically interpolate colors based on user-defined settings. - Added markdown documentation and an image for the dancing blob experiment to improve project visibility and context. These changes enhance user experience by ensuring microphone permissions are handled gracefully and provide more customization options for the dancing blob visuals * feat: update space game components and enhance performance - Refactored multiple components in the space game, including `index.vue`, `TheExperience.vue`, and various 3D models, to improve structure and performance. - Replaced `useLoader` with `useGLTF` for loading models, enhancing efficiency and reducing unnecessary asynchronous calls. - Updated the rendering logic in `Rig.vue` and `Enemies.vue` to utilize `onBeforeRender` for better performance during the game loop. - Enhanced the `Stars.vue` component to allow optional count prop and improved the template structure for better readability. - Added a new markdown file and image for the space game experiment to enhance documentation and provide context for the scene. These changes significantly improve the maintainability, performance, and documentation of the space game components. * refactor: streamline imports in 3D components for improved clarity - Removed unused imports from `Rocks.vue` and `PumpkinIvysaur.vue`, enhancing code clarity and reducing unnecessary dependencies. - Simplified the import statements in `sun.vue` by removing unused variables, contributing to cleaner and more maintainable code. These changes improve the overall readability and maintainability of the 3D components. * refactor: clean up Marble.vue and index.vue for improved readability and performance - Streamlined import statements in `Marble.vue` by removing unused variables, enhancing code clarity. - Simplified the animation logic in `Marble.vue` by ensuring consistent formatting and removing unnecessary whitespace. - Updated `index.vue` in `meshReflectionMaterial` to improve the structure of the rendering logic and ensure proper type handling in the `onBeforeRender` function. These changes enhance the overall maintainability and performance of the components. * feat: add Galaxy component and enhance galaxy generation logic - Introduced a new `Galaxy.vue` component for generating and rendering a dynamic galaxy using Three.js and TresJS. - Implemented shader logic with vertex and fragment shaders to create visually appealing galaxy effects. - Updated `index.vue` to integrate the new `Galaxy` component, improving the overall structure and maintainability of the galaxy generator. - Added a markdown file and image for the galaxy generator experiment to enhance documentation and provide context for the scene. These changes significantly improve the visual representation and functionality of the galaxy generator. * chore: update package dependencies and improve markdown tags - Removed ignored built dependencies from `package.json` and added an override for `ipx` to version `^3.0.3`. - Updated `pnpm-lock.yaml` to reflect the new dependency versions, including `sharp` and `ipx`. - Corrected markdown tags in `dancing-blob.md` and `synthwave-landscape.md` for consistency, changing 'shader' to 'shaders'. These changes enhance dependency management and improve documentation clarity. * chore: update Netlify configuration and npm settings - Added NODE_VERSION to the Netlify build environment for consistency across deployments. - Included a redirect rule in the Netlify configuration to ensure proper routing to index.html. - Updated .npmrc to include auto-install-peers and strict-peer-dependencies settings for improved package management. These changes enhance deployment configuration and package handling for the project. * feat!: nuxt 4 * chore: add Netlify configuration for build settings - Created a new `netlify.toml` file to define build commands and environment settings for deployment. - Specified the build command to run `pnpm run build` and set the publish directory to `.output/public`. - Added `NODE_VERSION` to ensure consistent Node.js version across deployments. These changes establish a foundational configuration for deploying the project on Netlify. * chore: add better-sqlite3 dependency to package.json - Included `better-sqlite3` version `^11.7.0` in `package.json` to enhance database handling capabilities within the project. This addition improves the project's ability to manage SQLite databases efficiently. * chore: update pnpm-lock.yaml to include better-sqlite3 and other dependency adjustments - Added `better-sqlite3` version `11.10.0` to `pnpm-lock.yaml` to enhance database handling capabilities. - Updated various dependencies in the lock file to reflect the latest versions and ensure compatibility across the project. These changes improve the project's dependency management and database handling efficiency. * fix: correct markdown tags in spooky-saur.md - Removed an unnecessary comma from the tags array in `spooky-saur.md` to ensure proper markdown formatting. This change enhances the clarity and correctness of the markdown file. * refactor: enhance Halloween decorations and improve component structure - Updated `HalloweenDecorations.vue` to utilize `computed` properties for flame attributes and improved state management with `watch`. - Refactored `PumpkinIvysaur.vue` to align with the new state management approach. - Adjusted camera positioning and target in `index.vue` for better scene composition. - Replaced `TresFog` and `EffectComposer` components with their updated counterparts for improved rendering effects. - Added a new image asset `spooky-saur.png` to enhance visual content. These changes improve the overall functionality, maintainability, and visual quality of the spooky-saur components. * chore: update .gitignore to include AI Assistant configurations - Added entries for `.cursor/`, `.claude/`, and `CLAUDE.md` to the `.gitignore` file to prevent tracking of AI Assistant related files and directories. This change helps maintain a cleaner repository by ignoring unnecessary configuration files. * feat: refactor-page-structure (#260) * feat: refactor component approach - Introduced several new components including `KnightRigged.vue`, `David.vue`, and `Lamb.vue` to expand the 3D scene capabilities. - Added `TresGridHelper` and `TresDirectionalLight` to improve lighting and grid visualization in the `array-cameras` and `brownian-distribution` experiments. - Implemented new shaders for various components to enhance visual effects. - Removed outdated components from the `content` directory to streamline the project structure. - Updated markdown files to reflect the latest changes and improve documentation clarity. These additions and modifications enhance the overall functionality and visual quality of the project. * feat: refactor approach for components - Introduced multiple new components including `TheDavid.vue`, `CultOfTheLamb.vue`, `DancingBlob.vue`, and `HauntedHouse.vue` to enhance the 3D scene capabilities. - Implemented new global styles and configurations for improved visual consistency across components. - Added various lighting and environmental effects to enrich the user experience in the 3D scenes. - Refactored existing components to utilize the latest features and best practices in Vue 3 and TresJS. These additions significantly enhance the overall functionality and visual quality of the project, providing users with a more engaging experience. * chore: update Netlify configuration and component adjustments - Changed the build command in `netlify.toml` from `pnpm run build` to `pnpm run generate` for static site generation. - Updated Node.js version from `20` to `22` for compatibility with the latest features. - Enabled the `TresMesh` component in `ThePumpkin.vue` by uncommenting the line to ensure proper rendering. - Simplified action methods in `GameStore.ts` by removing unused parameters for better clarity and maintainability. - Removed unused `bloomParams` reactive object in `index.global.vue` to streamline the component. These changes improve the deployment configuration and enhance the clarity of the component code. * chore: update Netlify build configuration - Modified the build command in `netlify.toml` to increase memory allocation with `--max-old-space-size=4096` for improved performance during static site generation. - Changed the publish directory from `.output/public` to `dist` to align with the updated build output structure. These adjustments enhance the deployment process and ensure better resource management during builds. * chore: update Netlify build configuration for output directory - Changed the publish directory in `netlify.toml` from `dist` to `.output/public` to align with the updated build output structure. - Retained the memory allocation setting in the build command for improved performance during static site generation. This adjustment ensures the deployment process is consistent with the latest build configurations. * chore: update Netlify build configuration by removing the publish directory - Removed the `publish` entry from `netlify.toml` to streamline the build configuration as it is no longer necessary. - This change simplifies the deployment process and aligns with the latest build output structure. * chore: simplify Netlify build command in configuration - Removed the memory allocation setting `--max-old-space-size=4096` from the build command in `netlify.toml` to streamline the build process. - This change aligns with the current requirements and simplifies the deployment configuration. * feat: add image format support in Nuxt configuration - Introduced support for `webp` and `avif` image formats in the Nuxt configuration to enhance image optimization and loading performance. This addition improves the overall efficiency of image handling within the project. * feat: add toggle functionality to TheCodeButton component - Introduced a visibility toggle for the `TheCodeButton` component using keyboard shortcuts. The button is now conditionally rendered based on the `visible` state, which can be toggled with the 'h' key. - This enhancement improves user interaction by allowing users to show or hide the button dynamically. * feat: enhance content configuration and introduce TheActions component - Updated the content configuration to include an exclusion for `CLAUDE.md` in the experiments collection, improving content management. - Added a new `TheActions` component to provide interactive functionality, including dark mode toggle and visibility controls for additional information related to the page. - Refactored `TheCodeButton` to dynamically generate GitHub links based on the current route, enhancing user experience. - Improved the `experiment.vue` layout by integrating the `TheCodeButton` and `TheActions` components for better accessibility and interaction. These changes enhance the overall functionality and user engagement within the application. * fix: update title templates for improved SEO handling - Modified the title template in `app.vue` to conditionally include the page title, enhancing SEO effectiveness. - Adjusted the title in `[...slug].vue` to remove the suffix, ensuring a cleaner title presentation. - Removed the static title in `index.vue` to allow for dynamic title management. These changes improve the overall SEO strategy and title management across the application. * feat: enhance TheActions component and update experiment markdown files - Refactored `TheActions.vue` to improve layout and styling, including a more structured title presentation with flexbox for better visual hierarchy. - Updated multiple experiment markdown files to include detailed descriptions, technical implementations, and visual features, enhancing documentation clarity and user engagement. - Added new content to various experiments, showcasing advanced techniques and features, such as audio-reactive visuals, procedural generation, and interactive elements. These changes improve the overall functionality, documentation, and user experience across the application. * feat: implement haunted house scene with building, floor, and ghost components - Added `Building.vue` to create a detailed haunted house structure with textured walls and door. - Refactored `floor.vue` to utilize `useTextures` for efficient texture loading and improved material options. - Updated `ghosts.vue` to use `onBeforeRender` for ghost animations, enhancing performance. - Removed the outdated `house.vue` component to streamline the project structure. - Updated `index.global.vue` to reference the new `Building` component. - Created a new markdown file for the haunted house experiment, detailing its features and technical implementation. These changes enhance the overall visual quality and functionality of the haunted house scene, providing an immersive experience. * feat: webgpu (#262) * feat: webgpu example with TSL shaders * feat: update camera position and enhance scene components in WebGPU renderer * feat: add thumbnails to experiment markdown files and update webgpu experiment date * feat: add TheScreenshot component to various experiments and include haunted house image * feat: add featured property to experiments and update related components * feat: add lucide icon set to dependencies in package.json and pnpm-lock.yaml * feat: dancing cube boy (#263) * feat: add Cube Boy Dancefloor experiment with animations, lighting, and music * refactor: clean up Cube Boy component by removing unused animation logic and console logs * feat: grainy liquid blob (#261) * feat: add grainy liquid effect with Blob component and shaders - Introduced `Blob.vue` to create a dynamic grainy liquid effect using Three.js shaders. - Added `Experience.vue` to manage the scene setup, including camera and lighting configurations. - Created vertex and fragment shaders for realistic liquid movement and color mixing. - Implemented a global entry point in `index.global.vue` to render the grainy liquid experience. - Added TypeScript definitions for shader files to ensure type safety. - Documented the grainy liquid experiment in a new markdown file for clarity and reference. These additions enhance the visual effects and interactivity of the application, providing a more engaging user experience. * feat: introduce MultiBlob component for enhanced grainy liquid effect - Added `MultiBlob.vue` to render multiple `Blob` instances with configurable properties for position, scale, and color, enhancing the visual complexity of the grainy liquid effect. - Updated `Blob.vue` to accept props for color and animation parameters, allowing for dynamic customization. - Refactored `Experience.vue` to utilize `MultiBlob` instead of a single `Blob`, improving scene depth and interaction. - Created `WebsiteLayout.vue` to structure the main layout, integrating the 3D canvas and content overlay for a cohesive user experience. - Enhanced fragment shader to improve the grain effect, adding more texture and depth to the visual output. These changes significantly enhance the visual richness and interactivity of the grainy liquid experience, providing users with a more engaging and dynamic interface. * fix: adjust amplitude value in MultiBlob component for improved visual effect - Updated the amplitude property in `MultiBlob.vue` from `0.06` to `0.8` to enhance the visual dynamics of the grainy liquid effect. This change aims to create a more pronounced and engaging interaction within the scene. * feat: enhance grainy liquid experiment documentation and component details - Updated the title and description in `grainy-liquid.md` to reflect the addition of animated liquid blobs and improved technical details. - Expanded the documentation to include a comprehensive overview of the shader system, component architecture, and key features of the liquid blobs. - Added detailed explanations of the vertex and fragment shaders, highlighting their roles in creating organic deformation and surface effects. - Included a breakdown of the `Blob` and `MultiBlob` components, detailing their props and functionalities for better understanding and customization. - Enhanced the overall clarity and depth of the experiment documentation, showcasing the technical implementation and design inspiration behind the grainy liquid effect. * feat: WIP porsche 911 showcase (#258) * feat: WIP porsche 911 showcase * feat: implement CameraRig, Lightformers, and Porsche components for enhanced 3D showcase * feat: Refactor car showcase component and update TresJS logo - Removed unused imports from the car showcase component. - Wrapped the TresCanvas in a div for better layout control. - Added a logo and attribution text at the bottom of the car showcase. - Updated the TresJS logo SVG with a new design. * feat: update car showcase metadata and add showcase image * feat: add date to car showcase metadata and include showcase image * chore: update dependencies in package.json and pnpm-lock.yaml - Bump versions of several dependencies including @nuxt/eslint, @nuxt/ui-pro, @vueuse/nuxt, better-sqlite3, three, and vue to their latest stable releases. - Update devDependencies for @iconify-json packages, @nuxt/content, @nuxt/icon, @nuxt/image, @nuxt/kit, and @Tresjs packages to ensure compatibility and improvements. - Adjusted the version of vite and related packages to enhance build performance and stability. - Cleaned up outdated package references and ensured all dependencies are aligned with the latest versions for better project maintenance. * refactor: clean up components and improve type safety - Removed unused template from `TheScreenshot.vue`. - Refactored position update logic in `Lightformers.vue` for clarity and readability. - Updated type annotations in `shaderMaterial.ts` from `Array<any>` to `Array<unknown>` for better type safety. - Renamed control variables in `Blob.vue` for improved clarity and consistency. - Removed unused loading states in `Building.vue` and `floor.vue` components. - Updated array mapping in `Background.vue` to use `unknown` instead of `any`. - Simplified the `onLoop` function in `Rocket.vue` for better readability. - Enhanced type definitions in `GameStore.ts` for actions and improved clarity in the update logic. * feat: enhance HologramCube component with improved type safety and performance - Added `TresObject` type for better type safety in the `traverse` method. - Introduced `useGLTF` for optimized GLTF model loading. - Replaced `timerGlobal` with `time` for consistent time management in shader calculations. - Updated the `glitchStrength` and `stripes` calculations to utilize `uniform` for improved performance. - Cleaned up the template for better readability and structure. * fix: adjust position of HologramCube component for improved rendering - Set the position of the primitive object in the HologramCube component to [0, 1, 0] to enhance its visibility and alignment within the scene. This adjustment aims to improve the overall rendering and user experience of the component. --------- Co-authored-by: Damien Montastier <montastier.damien@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.