-
Notifications
You must be signed in to change notification settings - Fork 35
Open
Labels
Description
Frequently, the module loaded through a scenario file requires additional imports, e.g., from Tribler. When a module cannot be imported, an error is printed to standard output but the experiment continues (even though the remainder of the module will not be active). This is because we are dynamically loading modules. See for example the following log output:
2022-02-18 07:44:06,796:WARNING:Scenario file gigachannel_small.scenario not found, attempting scenario file in experiment dir
2022-02-18 07:44:06,796:INFO:Scenario file found, using /var/scratch/pouwelse/jenkins2/workspace/validation_experiments/validation_experiment_gigachannels/gumby/experiments/gigachannel/gigachannel_small.scenario
2022-02-18 07:44:06,884:INFO:Unable to load gumby.modules.tribler_module as a local module, exception: No module named 'tribler_common'
2022-02-18 07:44:06,885:ERROR:Unable to import tribler_module from /var/scratch/pouwelse/jenkins2/workspace/validation_experiments/validation_experiment_gigachannels/gumby/gumby/modules as gumby.modules.tribler_module: No module named 'tribler_common'
2022-02-18 07:44:06,885:ERROR:Unable to import gumby.modules.tribler_module.TriblerModule (from tribler_module:1)
NoneType: None
2022-02-18 07:44:06,885:INFO:Loading module: gumby.modules.tribler_module.TriblerModule
2022-02-18 07:44:06,885:ERROR:ExperimentModule subclass expected in /var/scratch/pouwelse/jenkins2/workspace/validation_experiments/validation_experiment_gigachannels/gumby/experiments/gigachannel/gigachannel_small.scenario:1. Got: gumby.modules.tribler_module.TriblerModule
We could identify these kind of bugs earlier by exiting the process with a non-zero exit code when an import error occurs. The experiment should report a 'failure' status if one of the processes exits with a non-zero exit code.
Reactions are currently unavailable