feat(node-gha,github-action): support Node.js GitHub Action releases#151
Merged
Conversation
Coverage Report for CI Build 28377826404Coverage increased (+1.3%) to 63.003%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new @simple-release/node-gha package to publish “GitHub Action style” release refs (latest/major branches and version tags) and wires it into repo docs/workspace metadata. Also adjusts the GitHub Action releaser step order so “release” happens after “publish” (consistent with publishing/updating refs before creating a GitHub release).
Changes:
- Introduce
@simple-release/node-gha(project wrapper, publish implementation, config, linting, and tests). - Update the GitHub Action releaser pipeline to run
.publish()before.release(). - Update root README and
pnpm-lock.yamlto include the new package.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds @simple-release/node-gha to the package list and badge references. |
| pnpm-lock.yaml | Adds workspace importer entry for packages/node-gha and updates a dev dependency lock entry. |
| packages/node-gha/tsconfig.json | Adds package TS config (matches existing package pattern). |
| packages/node-gha/tsconfig.build.json | Adds build TS config for emitting to dist. |
| packages/node-gha/src/publish.ts | Implements publishing logic for latest/major branches and version tags, with optional build + staging/amend. |
| packages/node-gha/src/publish.spec.ts | Adds unit tests covering default and customized ref publishing behavior. |
| packages/node-gha/src/project.ts | Adds NodeGhaProject wrapper around PackageJsonProject publish step. |
| packages/node-gha/src/index.ts | Exports package public API. |
| packages/node-gha/README.md | Documents install/usage and publish options. |
| packages/node-gha/package.json | Defines new package metadata/scripts/deps. |
| packages/node-gha/oxlint.config.ts | Adds per-package oxlint config extending repo defaults. |
| packages/github-action/src/releaser.ts | Reorders release pipeline to publish before creating the GitHub release. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ? options.build | ||
| : [options.build] | ||
| : [] | ||
| const files = options.files || pkg.files as string[] || [] |
| expect(refHash(latestRef)).toBe(refHash(majorRef)) | ||
| expect(refHash(latestRef)).toBe(refHash(tagRef)) | ||
| expect(await project.gitClient.exec('show', 'v2.5.0:dist/index.js')).toBe('built') | ||
| expect(await project.gitClient.getCurrentBranch()).toBe('master') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.