Stricter Edge Selection Road Name Match#28
Merged
Conversation
…of using contains
tsweckard
changed the title
mdorford
approved these changes
Jun 4, 2026
chansbtran
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The BufferResource was generating a path that went down South Camp Butler Road instead of staying on Camp Butler Road.
Solution
When we were getting road names from external systems, we had to be more relaxed on road name matching. We recently improved our logic by using the road name of the first edge that we find so that we're consistently using OSM's road names and we don't need to be as relaxed on road name matching. Changed
.Contains(roadName)to.Equals(roadName)Testing
Regression tested