This repository was archived by the owner on Jun 24, 2025. It is now read-only.
build: use webpack for excalidraw #1537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be used for copying excalidraw fonts as assets
this will now end up in "src/public/app-dist/excalidraw/fonts/" excalidraw *needs* the fonts to be in a folder called "fonts" as it appends the "EXCALIDRAW_ASSET_PATH" variable with "fonts" automatically -> therefore switch names around to fix the issue
used for the fonts excalidraw requires
it is bundled by webpack now
these are only used for excalidraw and are bundled by webpack now
Contributor
Author
|
asset copying and loading works nicely: now just need to run some builds and test, if moving excalidraw/react/react-dom to devDeps did NOT break anything |
Contributor
Author
|
I could not see any issues with my locally build "webpack only" version :-) There were two small "issues", which are present in the previous version as well: a) excalidraw also tries to load some other fonts and fails with a 404 → TriliumNext/Trilium#5596 I'll create separate issues for these so that we can track and fix them eventually |
eliandoran
approved these changes
Mar 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIPThis PR aims to:the latter will save us ~69 MB of disk space in the final output (currently the @excalidraw node_modules folder weighs 82MB overall, the fonts, which we copy to app-dist weigh 13MB -> so 69MB of saving :-))