[6.x] Core/Quest: The Taste Test

[Maibenrai]

rev. 00b4e8b
http://www.wowhead.com/quest=12645/the-taste-test

Hemet's taste test - OK
Hadrius' taste test - OK
Tamara's taste test - Doesn't want to taste.

[Maibenrai]

Abandoned and tried again. Now in the order they are displayed:
Tamara - OK
Hadrius - OK
Hemet - No reaction

Looks like you are getting an intermittent issue, (meaning the bug does not always appear, or maybe can not be reproduced the same way each time). We need confirmation from other users on this issue.

[Killyana]

You can validate 2 criteria, but the 3rd one cannot be, the last npc will not trigger the script on spell hit, the order doesn't matter it always fail on the last one, also tested on 3.3.5 and this issue doesn't happen.

@Maibenrai : this is the current diff between 6.x and 3.3.5. Would you care to test if this works?

diff --git a/src/server/scripts/Northrend/zone_sholazar_basin.cpp b/src/server/scripts/Northrend/zone_sholazar_basin.cpp
index e0c7e4b..6e4a8df 100644
--- a/src/server/scripts/Northrend/zone_sholazar_basin.cpp
+++ b/src/server/scripts/Northrend/zone_sholazar_basin.cpp
@@ -493,15 +493,16 @@ public:
             if (!quest)
                 return;

-            if (player->GetQuestStatus(QUEST_TASTE_TEST) != QUEST_STATUS_INCOMPLETE)
+            QuestStatusMap::const_iterator itr = player->getQuestStatusMap().find(QUEST_TASTE_TEST);
+            if (itr->second.Status != QUEST_STATUS_INCOMPLETE)
                 return;

-            for (uint32 i = 0; i < quest->Objectives.size(); ++i)
+            for (uint8 i = 0; i < 3; ++i)
             {
-                if (uint32(quest->Objectives[i].ObjectID) != me->GetEntry())
+                if (uint32(quest->RequiredNpcOrGo[i]) != me->GetEntry())
                     continue;

-                if (player->GetQuestObjectiveData(quest, i) != 0)
+                if (itr->second.CreatureOrGOCount[i] != 0)
                     continue;

                 player->KilledMonsterCredit(me->GetEntry());

Please notice: this is only the result from overwriting the 6.x lines with the 3.3.5 script lines.

[Maibenrai]

Hi @tkrokli
I'll try to test it today (28.) when I have time :)

[Maibenrai]

Got errors:

C:\SRC\TrinityCore\src\server\scripts\Northrend\zone_sholazar_basin.cpp(502): error C2039: 'RequiredNpcOrGo' : is not a member of 'Quest'
          C:\SRC\TrinityCore\src\server\game\Quests\QuestDef.h(278) : see declaration of 'Quest'
C:\SRC\TrinityCore\src\server\scripts\Northrend\zone_sholazar_basin.cpp(505): error C2039: 'CreatureOrGOCount' : is not a member of 'QuestStatusData'
          C:\SRC\TrinityCore\src\server\game\Quests\QuestDef.h(501) : see declaration of 'QuestStatusData'

Thanks for the feedback, my diff is clearly not enough. "It needs more cowbell." I will see what I can do.

[Maibenrai]

RequiredNpcOrGo and CreatureOrGOCount missing from 6.x quest.template?

/src/server/game/Quests/QuestDef.h is different in 6.x compared to 3.3.5, that is what those error messages are talking about. The 6.x source is a lot more adapted to the repeated opcode changes.
The quest script needs an update or rewrite based on the existing 6.x source code, for compatibility.

[Aokromes]

This bug is still valid?

Yes, it is even worse now. I just took it on a new character set to level 80, but none of them will taste.
TrinityCore rev. f663743 2016-06-18 16:23:55 +0200 (6.x branch) (Win64, Release, Static)
TDB 6.04 plus updates up to and including 2016_06_17_01_world.sql

The 3 NPCs behave as if I don't even have the quest yet. No options what so ever. I even tried completing the all the quests they offer, but that did not help anything. The only result I got was that Hemet Nesingwary (@ base camp) and Tamara Wobblesprocket (@ River's Heart) do not even offer me any gossip window at all, while <Stable Master> Hadrius Harlowe only shows his default gossip Greetings, $c. I can assist you in recovering lost companions.