Quest mobs not skinnable after dropping quest items when grouped

[BittyBit]

Description: Quest mobs not skinnable after dropping quest items when grouped

Current behaviour:

Normally skinnable mobs that drop quest items are not skinnable after being looted.

Expected behaviour:

Skinnable mobs that drop quest items for players that are grouped should be skinnable by anyone after being looted.

Steps to reproduce the problem:

1. Form a party
2. Kill a skinnable mob that drops a quest item for the first party member to loot the mob
3. Regardless of 'whose mob it is to loot' designation, the mob will be unskinnable even if all party members loot it. The mob behaves like it is still holding the quest item for the other party members, but there is no quest item available.

This affects any quest of the type where a skinnable quest mob drops a quest item for only one member of a group. I have included the following quest/item/mob for reference.

• http://wowwiki.wikia.com/wiki/Quest:Pridewings_of_Stonetalon
• http://wowwiki.wikia.com/wiki/Pridewing_Venom_Sac
• http://wowwiki.wikia.com/wiki/Pridewing_Wyvern

Branch(es): 3.3.5 (not tested on master)

TC rev. hash/commit:

TrinityCore rev. 97f33dc 2017-11-11 20:27:30 +0100 (3.3.5 branch) (Unix, RelWithDebInfo, Static) (authserver)

Operating system: Ubuntu 16.04LTS

[Killyana]

Dup #13940

[BittyBit]

That issue refers to a random, and occasional unskinnable mob while ungrouped. This issue is consistent and repeatable.

[Killyana]

It depends if the drop rate of the quest item is 100% or not

So... move the issue description from this page to ticket #13940 then?

[BittyBit]

Just for clarification, when I said :

Kill a skinnable mob that drops a quest item for the first party member to loot the mob

I was trying to say that the issue only impacts mobs that drop the quest item. To build on the example I gave, if a Pridewing Wyvern doesn't drop a Pridewing Venom Sac (even if all or single group members have the quest) there is no issue skinning.

I did some testing and found that:

A mob that drops the quest item cannot be skinned by players inside or outside of the party if it has dropped the quest item for a player that is grouped
A mob that drops the quest item can be skinned by an ungrouped player once looted (expected) even if it has dropped the quest item for the ungrouped player. Once looted, the mob can also be skinned by a third party (again expected).
A mob that doesn't drop the quest item even if one or more party members have the quest, can be skinned by players either inside or outside of the party once the 'loot owning' player has looted it or unlocked it for another player to loot (expected).

I think that not dropping the quest items for all party members is blizzlike (circa wotlk) as is allowing the non-loot owner group member to ninja-loot the quest item. It is how the mob is flagged as skinnable after the loot operation that seems to be the issue.

[Killyana]

So the mob must not be flagged skinnable until everything is looted?
If you think so, we need a proof that it'is the retail behavior.

[offl]

Seems to be true
https://youtu.be/xoF5dOBJd34?t=68
https://youtu.be/iMjHAqLHDbc?t=42

[Killyana]

http://wowwiki.wikia.com/wiki/Skinning

• All the items from a corpse must be looted before it can be skinned.
• Any skinnable mobs will say "Skinnable" in their tooltip after they are dead and completely looted.
• If you're trying to skin something that is lootable by another player, that player must take all loot from the corpse, or you won't be able to skin it.
• In very uncommon circumstances, a corpse can contain a quest item that you can't see because you already filled your quota for that item. This usually happens when killing several mobs at once before looting and skinning them. There is no way to skin such a corpse other than to drop at least one of the quest items so you can then loot the item one more time. Due to game mechanics, random drops from mobs are almost always determined at the time of looting, rather at some previous time. And almost all looted items required for quests can be acquired beyond the quota for the quest. Rarely, this can happen with bosses who are supposed to drop a single quest item that respawn before their previous corpse has been looted, such as Combat 15 Princess.
• If you possess a Unique item somewhere in your inventory (bags/bank), and the mob has dropped that exact same item as lootable, you will be unable to loot it because you can only have one of any Unique item. As such, you will be unable to skin that mob.

So the npc must be flagged skinnable only when everything is looted.

[Killyana]

I made some tests an the npc doesn't get the skinnable flag until everything is looted, so it's blizzlike.

[BittyBit]

Was this closed because you are combining it with another ticket or because you feel that it is working as intended/blizzlike?

In very uncommon circumstances, a corpse can contain a quest item that you can't see because you already filled your quota for that item.

I am aware of that behavior and that is not the issue. It can be the first mob and first quest item that drops and it still exhibits the behavior.

The issue is that the mob doesn't get flagged skinnable after everyone has looted it, and that is not blizzlike. It seems like there isn't a good check to see if the quest item was picked up by any party member as opposed to every party member when it only drops for one player. This causes the mob not to be flagged skinnable when it should be flagged.

I did not notice the problem until trying to level skinning while questing/leveling in a group. If you try it you'll understand that it isn't behaving as expected.