Scripts/Naxxramas: Thaddius: Complete rewrite #15523

Treeston · 2015-09-16T02:15:15Z

Full rewrite of the Thaddius encounter. Stuff fixed, among others:

Encounter properly resets if the raid wipes at any point during the encounter (fixes and closes Thaddius- naxx #6888)
Polarity Shift works properly (fixes and closes [Encounter/Raid] Naxxaramas Thaddius #10126)
Visual spells used properly
Thaddius is now immobile and will no longer chase the tank
Tesla Coil leashes on Feugen/Stalagg work properly (cast chain lightning on raid if dragged off the platform)
Achievement criteria for Shocking! fixed to trigger properly, and only on appropriate difficulty (fixes and closes [Achievements] Shocking [10/25] #4751)
Way too many other corrections to count

PS: My first full rewrite of a boss AI. Some stuff may be done incorrectly. Please tell me how to do it better. Thanks.

ghost · 2015-09-16T08:09:18Z

There are many wrongs in this PR :(

Code style is a train wreck

ghost · 2015-09-16T08:10:13Z

src/server/scripts/Northrend/Naxxramas/boss_thaddius.cpp

Intentional missing break?

ccrs · 2015-09-16T16:37:39Z

src/server/scripts/Northrend/Naxxramas/boss_thaddius.cpp

i think its better to call this on reset as its also called on spawn.

leave constructor to initialize variables.

joschiwald · 2015-09-16T20:02:11Z

sql/updates/world/2015_09_14_00_world.sql

scriptname wasn't already assigned?

I think it was, actually. Should I remove the statement?

The update commands don't do any harm, they are just redundant if the names are there already.

Yeah, figured I'd put them in for everything that has an AI from this script.

pls remove unneeded sql queries

joschiwald · 2015-09-16T20:05:05Z

how many stuff is confirmed with sniffs?

ghost · 2015-09-16T21:22:27Z

src/server/scripts/Northrend/Naxxramas/boss_thaddius.cpp

Please explain this part, the grid is very likely to be active while the players are inside the room

Just trying to prevent weirdness if the last person to drop from combat is also the last person that hasn't released and leaves grid just as they exit combat (hearthstone etc.)

BossAI does it using the default _EnterCombat, too, which is where I got the idea.

jackpoz · 2015-09-18T07:31:23Z

I would consider this PR ready for merging.

I would consider this PR ready for testing, maybe with static/dynamic analysis tools too

jackpoz · 2015-09-18T07:32:28Z

sql/updates/world/2015_09_14_00_world.sql

does this value allow anyone to locally merge this PR and try it out ?

It merged fine on a clean TDB for me.

I told him to use such huge guid to avoid travis blaming because SET @Cguid = XXXX; and be sure it don't uses existing guids :P ofc when merged it must be changed to unused guids on range 1-213000.

kk, so anyone can test this PR ingame and provide any feedback

Treeston · 2015-09-18T12:06:59Z

Any test results are much appreciated. I tried pretty much every constellation of weird encounter resets that I could think of and the encounter never broke, but I'm sure someone else can come up with something that I didn't think of.

Also, please report stuff, even minor stuff, that doesn't match retail if you have retail experience.

ghost · 2015-09-19T10:28:44Z

src/server/scripts/Northrend/Naxxramas/boss_thaddius.cpp

This will bug out if the damage is exactly equal to his health (rare cases, but happens).

Wouldn't it just make him "die" if damage is equal to his health (which is what's intended)? I may not be seeing it.

Yeah, nevermind that, I got the logic now

Treeston · 2015-10-10T10:32:01Z

Fixed SQL to conform to standards, and moved texts to creature_text instead of using broadcast_text directly.

Vincent-Michael · 2015-10-10T10:47:46Z

src/server/scripts/Northrend/Naxxramas/instance_naxxramas.cpp

remove c style

Treeston · 2015-10-22T17:43:10Z

Moved GUIDs again to be unused 2 GUID slots.

Treeston · 2015-10-31T23:17:00Z

Rebased.

Scripts/Naxxramas: Thaddius: Complete rewrite

Treeston changed the title ~~Creature/BossAI/Thaddius: Complete rewrite~~ Creature/BossAI/Thaddius: Complete rewrite [WIP] Sep 16, 2015

ghost reviewed Sep 16, 2015
View reviewed changes

src/server/scripts/Northrend/Naxxramas/boss_thaddius.cpp Outdated

Copy link

ghost Sep 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional missing break?

jackpoz added the Feedback-FixOutdatedMissingWIP label Sep 16, 2015

ccrs reviewed Sep 16, 2015
View reviewed changes

Treeston changed the title ~~Creature/BossAI/Thaddius: Complete rewrite [WIP]~~ Creature/BossAI/Thaddius: Complete rewrite Sep 16, 2015

joschiwald reviewed Sep 16, 2015
View reviewed changes

ghost reviewed Sep 16, 2015
View reviewed changes

Treeston force-pushed the 3.3.5-thaddius branch from dcc5110 to 2bd2113 Compare September 17, 2015 03:23

DDuarte removed the Feedback-FixOutdatedMissingWIP label Sep 17, 2015

jackpoz reviewed Sep 18, 2015
View reviewed changes

ghost reviewed Sep 19, 2015
View reviewed changes

Treeston force-pushed the 3.3.5-thaddius branch from 42c765d to 2d0931f Compare September 19, 2015 18:14

Treeston force-pushed the 3.3.5-thaddius branch from 2d0931f to ed0551f Compare October 1, 2015 22:28

Treeston force-pushed the 3.3.5-thaddius branch from ed0551f to f8508b7 Compare October 10, 2015 10:31

Vincent-Michael reviewed Oct 10, 2015
View reviewed changes

src/server/scripts/Northrend/Naxxramas/instance_naxxramas.cpp Outdated

Copy link

Contributor

Vincent-Michael Oct 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove c style

Treeston force-pushed the 3.3.5-thaddius branch 2 times, most recently from c7b81e8 to fecb007 Compare October 10, 2015 15:40

Treeston force-pushed the 3.3.5-thaddius branch from fecb007 to c8d2ae5 Compare October 22, 2015 17:39

Treeston force-pushed the 3.3.5-thaddius branch from c8d2ae5 to 80f339f Compare October 31, 2015 23:15

Treeston force-pushed the 3.3.5-thaddius branch 3 times, most recently from 9646fd3 to 487140d Compare November 2, 2015 17:08

Scripts/Naxxramas: Complete rewrite of the Thaddius encounter.

29feae5

Treeston force-pushed the 3.3.5-thaddius branch from 487140d to 29feae5 Compare November 8, 2015 13:59

Treeston changed the title ~~Creature/BossAI/Thaddius: Complete rewrite~~ Scripts/Naxxramas: Thaddius: Complete rewrite Nov 8, 2015

MitchesD added a commit that referenced this pull request Nov 12, 2015

Merge pull request #15523 from Treeston/3.3.5-thaddius

e14e291

Scripts/Naxxramas: Thaddius: Complete rewrite

MitchesD merged commit e14e291 into TrinityCore:3.3.5 Nov 12, 2015

This was referenced Nov 12, 2015

[DEV] Changelog (TDB: 335.61 & 6.04) #15821

Closed

[DEV] 3.3.5 -> 6.x cherry-picks (TDB: 335.61 & 6.04) #15819

Closed

This was referenced Nov 12, 2015

[Encounter/Raid] Naxxaramas Thaddius #10126

Closed

Thaddius- naxx #6888

Closed

Treeston deleted the 3.3.5-thaddius branch November 13, 2015 09:59

Scripts/Naxxramas: Thaddius: Complete rewrite #15523

Scripts/Naxxramas: Thaddius: Complete rewrite #15523

Uh oh!

Conversation

Treeston commented Sep 16, 2015

Uh oh!

ghost commented Sep 16, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joschiwald commented Sep 16, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jackpoz commented Sep 18, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Treeston commented Sep 18, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Treeston commented Oct 10, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Treeston commented Oct 22, 2015

Uh oh!

Treeston commented Oct 31, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants