Core/Scripts/DB: move npc_gregan_brewspewer to DB#17157
Conversation
Author
|
Regarding my SQL change to the UPDATE `npc_text` SET `BroadcastTextID0`= 0 WHERE `ID`= 2433;I have included the following explanation inside the SQL file: If you don't want this in the SQL file, I can remove it. I included it because I felt it needed to be explained. |
- Remove npc_gregan_brewspewer, thereby removing hardcoded text `#define GOSSIP_HELLO "Buy somethin', will ya?"` - Move all gossip handling to DB (gossip texts already exist in TDB)
Treeston
added a commit
that referenced
this pull request
Jun 9, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
npc_gregan_brewspewer, thereby removing the hardcoded text:zone_feralas.cppwith correct content / SD infoTarget branch(es): 3.3.5 / 6.x (Select the branch(es) affected by this issue)
Issues addressed: Updates mysterious-static#2 and the list of hardcoded text http://pastebin.com/x7wZLpxH
Tests performed: (Does it build, tested in-game, etc)
Known issues and TODO list:
No issues in this PR, only a testing "challenge" when the player needs to jump wall to get Evoroot
NOTE If your Pull Request is SQL only create a ticket instead
SUGESTION If your Pull Request contains SQL give it one imposible date, for example 9999_99_99_99_database.sql on that way it will be free on merge.
2016_05_19_99_world.sqlis a fairly unlikely file name for the SQL included.