Skip to content

Core/Scripts/DB: move npc_gregan_brewspewer to DB#17157

Merged
Treeston merged 1 commit into3.3.5from
unknown repository
Jun 9, 2016
Merged

Core/Scripts/DB: move npc_gregan_brewspewer to DB#17157
Treeston merged 1 commit into3.3.5from
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 19, 2016

Changes proposed:

  • Remove the script npc_gregan_brewspewer, thereby removing the hardcoded text:
#define GOSSIP_HELLO "Buy somethin', will ya?"
  • Move all gossip handling to DB (gossip texts already exist in TDB)
  • Update the core script file zone_feralas.cpp with correct content / SD info

Target branch(es): 3.3.5 / 6.x (Select the branch(es) affected by this issue)

  • 3.3.5 (the questline was removed from World of Warcraft in patch 4.0.3a)

Issues addressed: Updates mysterious-static#2 and the list of hardcoded text http://pastebin.com/x7wZLpxH

Tests performed: (Does it build, tested in-game, etc)

  • builds without any problems in VS2013 Update 5 (source code removal + verified SQL queries)
  • works as intended in-game (GM commands or wall jumping is required to complete the full quest)

Known issues and TODO list:

No issues in this PR, only a testing "challenge" when the player needs to jump wall to get Evoroot

NOTE If your Pull Request is SQL only create a ticket instead

  • this PR contains both SQL and C++ script code (removal)

SUGESTION If your Pull Request contains SQL give it one imposible date, for example 9999_99_99_99_database.sql on that way it will be free on merge.

  • 2016_05_19_99_world.sql is a fairly unlikely file name for the SQL included.

@ghost
Copy link
Copy Markdown
Author

ghost commented May 19, 2016

Regarding my SQL change to the npc_text table,

UPDATE `npc_text` SET `BroadcastTextID0`= 0 WHERE `ID`= 2433;

I have included the following explanation inside the SQL file:

Remove broadcast_text link from Gregan's default gossip "What can I do for ya?"
to enable npc_text.ID 2433 "Hi there! The name's Gregan. What can I do for ya?"
This mixup is caused by invalid duplicate use of BroadcastTextID0 = 8275,
duplicate of npc_text.ID 5695, used by NPC entry 5167 Fenthwick <Rogue Trainer>
Lookup queries to verify this information:

SELECT * FROM `npc_text` WHERE `BroadcastTextID0`= 8275; -- (ID 2433 + 5695)
SELECT * FROM `gossip_menu` WHERE `text_id`= 5695; -- (4561,5695)
SELECT * FROM `gossip_menu_option` WHERE `menu_id`= 4561; -- (id 0,1,2,4) "I'm lookin' for rogue trainin'."
SELECT * FROM `creature_template` WHERE `gossip_menu_id`= 4561; -- (5167 Fenthwick <Rogue Trainer>)

If you don't want this in the SQL file, I can remove it. I included it because I felt it needed to be explained.

- Remove npc_gregan_brewspewer, thereby removing hardcoded text
`#define GOSSIP_HELLO "Buy somethin', will ya?"`
- Move all gossip handling to DB (gossip texts already exist in TDB)
@Treeston Treeston merged commit 3acf6f3 into TrinityCore:3.3.5 Jun 9, 2016
Treeston added a commit that referenced this pull request Jun 9, 2016
@ghost ghost deleted the npc_gregan_brewspewer_gossip branch June 9, 2016 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants