Core/Packets: implement GAMEOBJECT_TYPE_UI_LINK#20919
Merged
joschiwald merged 1 commit intoTrinityCore:masterfrom Jan 4, 2018
DoctorKraft:gob-ui
Merged
Core/Packets: implement GAMEOBJECT_TYPE_UI_LINK#20919joschiwald merged 1 commit intoTrinityCore:masterfrom DoctorKraft:gob-ui
joschiwald merged 1 commit intoTrinityCore:masterfrom
DoctorKraft:gob-ui
Conversation
ghost
added
Branch-master
Comp-Core
Feedback-FixOutdatedMissingWIP
Sub-Miscellaneous
labels
Shauren
requested changes
Nov 17, 2017
Member
Shauren
left a comment
Shauren
left a comment
There was a problem hiding this comment.
And radius - isnt that simply the interaction distance limit?
| WorldPacket const* Write() override; | ||
|
|
||
| ObjectGuid ObjectGUID; | ||
| uint32 UILink = 0; |
| WorldPacket const* WorldPackets::GameObject::GameObjectUIAction::Write() | ||
| { | ||
| _worldPacket << ObjectGUID; | ||
| _worldPacket << UILink; |
Member
There was a problem hiding this comment.
always write the type for ints/floats (_worldPacket << int32(UILink);)
Contributor
Author
|
@Shauren yeah i think same, but i don't have any idea where to implement this. It's in GridNotifier? |
ghost
changed the title
Contributor
|
take a look at GameObject::GetInteractionDistance |
Contributor
Author
|
I have tried one but not working. For example i set 50 yards, when icon for interact are grayed you can do everything it's always same range (only when icon are not grayed). The structure contains also a spellfocus... |
Contributor
|
it looks like that all gameobjects have the default interaction range |
Contributor
|
merging in the next days |
Contributor
|
Gobs interaction range will be fixed by #18917 |
zgn1988
pushed a commit
to ProjectLegion/ProjectLegion
that referenced
this pull request
Jan 4, 2018
Aszune
pushed a commit
to Aszune/TrinityCoreRP
that referenced
this pull request
Mar 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Get UI for Obliterium Forge or Hero's Call Board with Adventure Journal
Target branch(es):
Issues addressed: Closes #20913
Tests performed: Build & tested in-game
Known issues and TODO list: