Fixed PvP Combat timer never getting refreshed #24058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
PvP combat needs other reworks as well, the combat manager is always working on the hypothesis that combat is always mutual, which is actually untrue in PvP. Example: If your target drop combat by vanishing it shouldn't affect your own combat state. A lot of more serious cases are affected by this but this one is easier to explain. |
Member
|
@Treeston please take a look at this when you have time |
Member
|
@kelno: actually you missed some code from SunstriderEmu/BugTracker@06d99c5 |
Member
|
I applied the feedback provided by Treeston |
Treeston
approved these changes
Jan 13, 2020
Contributor
|
Tested and works fine. |
Member
|
Thanks for the PR :) |
Ovahlord
referenced
this pull request
in The-Cataclysm-Preservation-Project/TrinityCore
Jul 22, 2020
* Fixed PvP Combat timer never gets refreshed while meleeing * Apply Treeston feedback Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Shauren
pushed a commit
that referenced
this pull request
Dec 21, 2021
* Fixed PvP Combat timer never gets refreshed while meleeing * Apply Treeston feedback Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com> (cherry picked from commit 2b024e8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Target branch(es):
Issues addressed:
Closes #22851
Tests performed: (Does it build, tested in-game, etc.)
Code running on sunstrider core for about a year. (sunstrider being basically TC for TBC at this point).
Known issues and TODO list:
/