Skip to content

Working Gunship Battle Event#9774

Closed
ghost wants to merge 5 commits intomasterfrom
unknown repository
Closed

Working Gunship Battle Event#9774
ghost wants to merge 5 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 9, 2013

Title says it all. Gunship Battle Event to ICC Raid.

People been asking about it and here it is.. This was been updated and now working well.

Finished:
Fixed Server Crash
Fixed Cannon Aim Angle
Fixed Encounter Frame
Fixed Ship Visibility
Fixed Wave Spawns

Reimi added 2 commits May 8, 2013 23:13
@ghost
Copy link
Copy Markdown
Author

ghost commented May 9, 2013

Referenced: #9773

@Aokromes
Copy link
Copy Markdown
Member

Aokromes commented May 9, 2013

I don't see any good reason to delete old sql files.

@Aokromes
Copy link
Copy Markdown
Member

Aokromes commented May 9, 2013

Also some clear hacks, like the use of custom creatures.

@gigatotem
Copy link
Copy Markdown
Contributor

The part where Muradin and Saurfang are set as unattackable is wrong.

On Retail 5.x (WOTLK content rarely gets changed) Muradin and Saurfang are attackable and do attack enemy players that are on their ship.

@ghost
Copy link
Copy Markdown
Author

ghost commented May 9, 2013

@Aokromes What your seeing is temp creature till I can recheck sniffs to make sure on the correct information. Yes some hacks are there, but they'll be cleared out soon.

The reason why I cleared out SQLs, is because why keep sqls from 2.4.3 to 3.3.3 when this is a 3.3.5a source. That's why.

@ Everyone It's progress, don't start complaining about incorrect things, when trinitycore has incorrect things as well. You guys complained about gunship and now someone got it for you.

@emptyus
Copy link
Copy Markdown

emptyus commented May 9, 2013

I was not complaining. I tried to be helpful. Sorry if that hurts your feelings :<

@ghost
Copy link
Copy Markdown
Author

ghost commented May 9, 2013

@emptyus It's okay, I misread what you said. Gunship Battle is the hardest code to write to be honest. Getting correct data for it, will be hard to do, because no one really runs ICC anymore. Thanks for the help though emptyus.. Over 6 months to get the thing working right, is a long time..

@Baeumchen
Copy link
Copy Markdown
Contributor

  • * Updated by: Toba and Baeumchen (maddin) <- At least you left that in there ;)

This script's are just up, because so many ppl wantet gunship battle. There are still many things do to, to make this 100% perfekt! I have still like 7 things on my todo list :P

@ghost
Copy link
Copy Markdown
Author

ghost commented May 9, 2013

@Baeumchen Agreed, alot of people want it, but only a select few can script it. Plus, I hope TrinityCore accepts it soon, because I don't know how long I'm going to keep this public.. It's their only chance on getting this now.

@ghost
Copy link
Copy Markdown
Author

ghost commented May 9, 2013

@Reimi they will never accept hacky codes like this, rather than that its not hard to recode this cuz ther'e hundreds of versions for that. they would highly just need the way to handle the transport but the rest ist s easy to recode. u just need the time and be bored enough to do this

@ghost
Copy link
Copy Markdown
Author

ghost commented May 9, 2013

@Northstrider Like I said before, I'm aware of it. Please stop repeating the same things over again. The rest why there are some hacks, is because getting the data from sniffs is kinda hard when people don't run ICC anymore. Plus you only can do the Raid once every 7 days, which can take longer to do. I think they understand that..

@balacas
Copy link
Copy Markdown

balacas commented May 9, 2013

@Reimi : I just want to thanks you for your work. The people don't want to share their work now, it's rare to see an open source.. So thanks.

@ghost
Copy link
Copy Markdown
Author

ghost commented May 9, 2013

@balacas Thanks for the wishes.. Best to fork it when you can.. Depending if TrinityCore takes it or not, it will be private source once again. I'm just doing it, cause I feel nice today..

Credit Markers for this script for this pull commit
Toba, Baeumchen, Reimi, & Terabyte

@Baeumchen
Copy link
Copy Markdown
Contributor

Wait.. WHAT!? You don't know, how long YOU are keeping this public? ^^ It will be public as long, as i want it to be public! :D

@ghost
Copy link
Copy Markdown
Author

ghost commented May 9, 2013

@Baeumchen If TrinityCore doesn't want it in the next few days, this pull request will be closed and forever lost. If you want the source, best to fork it while you can..

@Dokman
Copy link
Copy Markdown

Dokman commented May 9, 2013

@Reimi You know that MaNGOS rewrited all the visibility systems and the TransportKit() ?
i follow all the commits and for mangos it take it like 6 months or more and now is on a 75%.
i don't belelieve Trinitycore can has it because have a lot of hack code in the WorldLocations and posotions.

@ghost ghost mentioned this pull request May 9, 2013
@ghost
Copy link
Copy Markdown
Author

ghost commented May 9, 2013

@Dokman I'm sure the Transport System will/or has been rewritten in the past. 6 months ago, Gunship Battle Event always crashes on TC source, and after they updated the Vehicle System it never crashed.

@ghost ghost closed this May 9, 2013
@ghost ghost deleted the GunshipBattle branch May 9, 2013 20:38
@Baeumchen
Copy link
Copy Markdown
Contributor

By now i managed to fix the Server Crash, with the Axe throwers.. I'm now working on the Crash, when you are in Cannon before Event starts, also i fixed the never ending spawning mobs on the Ship + the Ship does not disappear, after event is finished... I'll update the Script within the next two weeks..

@ghost
Copy link
Copy Markdown
Author

ghost commented May 10, 2013

@Baeumchen Alright, there is 1 crash on one of the cannons on the Horde side of the event. I'll be updating my side of the transport system once I get time to do it, sense trinity won't do it. I also got more sniffs of the placements on the cannons including ori of them too, including more SAI for the mobs. Feel free to pass them on if you like too.

I closed this as well do to trinity not listening to what I was saying.

@Shauren
Copy link
Copy Markdown
Member

Shauren commented May 10, 2013

We will not merge this crappy script that you can find pretty much everywhere. Bunch of hacks and whatnot

@ghost
Copy link
Copy Markdown
Author

ghost commented May 10, 2013

@Shauren Suit yourself then.

@emptyus
Copy link
Copy Markdown

emptyus commented May 10, 2013

Man, this was wicked 🎯

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants