added CurrentLimits#145
Merged
nlaverdure merged 3 commits intomainfrom Mar 16, 2026
Merged
Conversation
- Add kDefaultStatorCurrentLimit (100A) to NEO, NEO Vortex, and Kraken X60 motor constants alongside existing supply limits - Drive: separate kSlipCurrent (120A, TorqueCurrent peak for slip detection) from kDriveStatorCurrentLimit (100A, hardware protection); add supply limit (60A) to driveInitialConfigs; fix steerInitialConfigs actually being applied by using constants.SteerMotorInitialConfigs as base in ModuleIOTalonFX - Flywheel: add supply limit (60A); apply config to follower TalonFX which was previously unconfigured - Intake rollers: add supply limit (60A); reference shared motor constants instead of magic numbers - Remove redundant maxCurrentAmps local constants from LauncherConstants and IntakeConstants now that values come from MotorConstants Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #143