Separate driver heading from pose estimation; fix auto pose init#179
Merged
nlaverdure merged 4 commits intomainfrom Mar 26, 2026
Merged
Separate driver heading from pose estimation; fix auto pose init#179nlaverdure merged 4 commits intomainfrom
nlaverdure merged 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
headingOffsetconcept is removed fromDrive. Driver-relative heading is now purely a UI concern managed byDriveCommands.driverForwardDirection, whiledrive.getPose().getRotation()is the single source of truth for field-relative heading.Drive.setPose()now properly resets the pose estimator (was previously only resetting the heading offset), and sets aposeInitializedflag sogetFieldRelativeHeading()returnsnulluntil the pose has field-relative meaning — preventing false vision yaw rejections at startup.Drive.getHeading()/resetHeading(): All callers now usedrive.getPose().getRotation()(field-relative) ordrive.getRawGyroRotation()(characterization) as appropriate. Vision heading supplier updated fromgetRawGyroRotationtogetFieldRelativeHeading.Test plan
🤖 Generated with Claude Code