Fixes #266 - MDC logging of the load balancer address now logs the proper address#355
Merged
dekobon merged 3 commits intoTritonDataCenter:masterfrom Oct 6, 2017
Merged
Conversation
This introduces a new implementation of a HttpRequestExecutor that logs the load balancer IP address and wraps Apache HTTP Client exceptions with exceptions that provide additional logging.
dekobon
changed the title
tjcelaya
approved these changes
Oct 6, 2017
Contributor
tjcelaya
left a comment
tjcelaya
left a comment
There was a problem hiding this comment.
LGTM, just had one comment about a small error in a JavaDoc.
| * @param message The detail message (which is saved for later retrieval | ||
| * by the {@link #getMessage()} method) | ||
| * @param cause The cause (which is saved for later retrieval by the | ||
| * {@link #getCause()} method). (A null value is permitted, |
Contributor
There was a problem hiding this comment.
Looks like this parameter description was cut off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new implementation of a HttpRequestExecutor that logs the load balancer IP address and wraps Apache HTTP Client exceptions with exceptions that provide additional logging.
I arrived at these changes after investigating an intermittent
NoHttpResponseExceptionbeing thrown and I needed more details about the request being made.